[yetus] 05/10: YETUS-889. change golangci-lint to give all output (#177)

[aw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aw pushed a commit to branch YETUS-1034-release
in repository https://gitbox.apache.org/repos/asf/yetus.git

commit 776481bdfb02afbb872e741a54ba05ffb918345c
Author: Allen Wittenauer <aw...@apache.org>
AuthorDate: Thu Oct 29 08:54:42 2020 -0700

    YETUS-889. change golangci-lint to give all output (#177)
---
 .../in-progress/precommit/plugins/golangcilint.html.md              | 2 +-
 precommit/src/main/shell/test-patch.d/golangci.sh                   | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/asf-site-src/source/documentation/in-progress/precommit/plugins/golangcilint.html.md b/asf-site-src/source/documentation/in-progress/precommit/plugins/golangcilint.html.md
index fdd6acf..5037393 100644
--- a/asf-site-src/source/documentation/in-progress/precommit/plugins/golangcilint.html.md
+++ b/asf-site-src/source/documentation/in-progress/precommit/plugins/golangcilint.html.md
@@ -27,7 +27,7 @@ Test
 
 # Description
 
-NOTE: Go support is experimental.  Additionally, this plug-in only supports Go using Go modules.
+NOTE: This plug-in only supports Go using Go modules.
 
 Provides support for
 [golangci-lint](https://github.com/golangci/golangci-lint).  This
diff --git a/precommit/src/main/shell/test-patch.d/golangci.sh b/precommit/src/main/shell/test-patch.d/golangci.sh
index 1866784..9d9ef47 100755
--- a/precommit/src/main/shell/test-patch.d/golangci.sh
+++ b/precommit/src/main/shell/test-patch.d/golangci.sh
@@ -83,9 +83,11 @@ function golangcilint_exec
     gargs=("cat")
   fi
 
-  args=("--color=never")
+  args+=("--max-issues-per-linter=0")
+  args+=("--max-same-issues=0")
   args+=("--out-format=line-number")
   args+=("--print-issued-lines=false")
+  args+=("--color=never")
 
   if [[ -f "${GOLANGCI_CONFIG}" ]]; then
     args+=("--config" "${GOLANGCI_CONFIG}")
@@ -103,7 +105,7 @@ function golangcilint_exec
       echo "${p}${REPLY}" >> "${PATCH_DIR}/${repostatus}-golangcilint-result.txt"
     done < <("${GOLANGCI_LINT}" run "${args[@]}" ./... 2>&1 \
       | "${gargs[@]}" \
-      | sort -t : -k 1,1 -k 2,2n -k 3,3n)
+      | sort -t : -k 1,1 -k 2,2n -k 3,3n -k 4)
     popd >/dev/null || return 1
   done
   return 0