You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/14 22:18:37 UTC

[GitHub] [avro] zcsizmadia commented on pull request #1549: AVRO-3402 Updated GenericWriter to meet style guidelines

zcsizmadia commented on pull request #1549:
URL: https://github.com/apache/avro/pull/1549#issuecomment-1039628288


   @KyleSchoonover @martin-g @RyanSkraba 
   I start to loose confidence in myself that this is the right way to handle this. I still beleive that this effort should be grouped by warning type and not by a massive to rework all warnings. IMO formatting warnings can be fixed easily, however changing massive code for reworking conditions and  casting seems dangerous to me. It is hard to review so much code and the compiler suggestion IMO cannot be trusted 100%. 
   
   Any comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org