[GitHub] [flink] klion26 opened a new pull request #10111: [FLINK-1396] Resuming Externalized Checkpoint (rocks, incremental, scale down) end-to-end test fails on Travis

[GitBox <gi...@apache.org>]

klion26 opened a new pull request #10111: [FLINK-1396] Resuming Externalized Checkpoint (rocks, incremental, scale down) end-to-end test fails on Travis
URL: https://github.com/apache/flink/pull/10111
 
 
   ## What is the purpose of the change
   
   Prevent triggering new checkpoints after the coordinator has been stopped.
   
   Currently, we only check whether the coordinator has been stopped, but only check in actual triggering checkpoint, in this pr we want to fix this.
   
   The event order will lead to this problem is 
   - triggerCheckpoint  eager pre-checks
   - job cancel
   - triggerCheckpoint actual trigger checkpoint
   
   all the three steps are guarded by lock, will release the lock after step 1 and require the lock in step 3.
   
   we checked whether the coordinator has been stopped in eager pre-checks, but not in actual trigger checkpoint.
   
   ## Brief change log
   
     - *Add a check whether the coordinator has been stopped when actual trigger checkpoint*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *Added test to verify this change in `CheckpointCoordinatorTest#testTriggerCheckpointAfterCancel`*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services