You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Helmut Swaczinna (JIRA)" <de...@myfaces.apache.org> on 2007/08/01 15:16:52 UTC
[jira] Created: (TOBAGO-459) Alignment for label
Alignment for label
-------------------
Key: TOBAGO-459
URL: https://issues.apache.org/jira/browse/TOBAGO-459
Project: MyFaces Tobago
Issue Type: Improvement
Components: Core
Affects Versions: 1.0.12
Environment: All
Reporter: Helmut Swaczinna
Priority: Minor
Fix For: 1.0.12
I've made a small extension to the Tobago tag lib to allow labels be right aligned or centered.
Example:
<tc:label align="right" .../>
Source code is attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-459) Alignment for label
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517510 ]
Bernd Bohmann commented on TOBAGO-459:
--------------------------------------
Already removed the width style from the label tag :-)
> Alignment for label
> -------------------
>
> Key: TOBAGO-459
> URL: https://issues.apache.org/jira/browse/TOBAGO-459
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.12
> Environment: All
> Reporter: Helmut Swaczinna
> Priority: Minor
> Attachments: label.diff
>
>
> I've made a small extension to the Tobago tag lib to allow labels be right aligned or centered.
> Example:
> <tc:label align="right" .../>
> Source code is attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-459) Alignment for label
Posted by "Helmut Swaczinna (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517494 ]
Helmut Swaczinna commented on TOBAGO-459:
-----------------------------------------
I think it's not done with a markup attribute because the align style works only if there's no width style for the label.
So if an alignment is present the width style must not be rendered.
> Alignment for label
> -------------------
>
> Key: TOBAGO-459
> URL: https://issues.apache.org/jira/browse/TOBAGO-459
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.12
> Environment: All
> Reporter: Helmut Swaczinna
> Priority: Minor
> Attachments: label.diff
>
>
> I've made a small extension to the Tobago tag lib to allow labels be right aligned or centered.
> Example:
> <tc:label align="right" .../>
> Source code is attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOBAGO-459) Alignment for label
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bernd Bohmann resolved TOBAGO-459.
----------------------------------
Resolution: Fixed
done by TOBAGO-460
> Alignment for label
> -------------------
>
> Key: TOBAGO-459
> URL: https://issues.apache.org/jira/browse/TOBAGO-459
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.12
> Environment: All
> Reporter: Helmut Swaczinna
> Priority: Minor
> Attachments: label.diff
>
>
> I've made a small extension to the Tobago tag lib to allow labels be right aligned or centered.
> Example:
> <tc:label align="right" .../>
> Source code is attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-459) Alignment for label
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517488 ]
Bernd Bohmann commented on TOBAGO-459:
--------------------------------------
Thanks for the patch. There is nothing wrong with the patch, but the prefered way in tobago is the markup attribute.
If all label should be centered extend a theme or write a own theme.
Added an issue markup attribute for label.
> Alignment for label
> -------------------
>
> Key: TOBAGO-459
> URL: https://issues.apache.org/jira/browse/TOBAGO-459
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.12
> Environment: All
> Reporter: Helmut Swaczinna
> Priority: Minor
> Fix For: 1.0.12
>
> Attachments: label.diff
>
>
> I've made a small extension to the Tobago tag lib to allow labels be right aligned or centered.
> Example:
> <tc:label align="right" .../>
> Source code is attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.