You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/24 10:16:32 UTC

[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #64: [refactor] Apply forward declaration as much as possible

BewareMyPower commented on PR #64:
URL: https://github.com/apache/pulsar-client-cpp/pull/64#issuecomment-1288787275

   @merlimat @shibd @RobertIndie @Demogorgon314  Please take a look at this PR in prior to other PRs since it brings many changes. Other PRs should be rebased to it.
   
   Though it's a huge PR, most changes are only related to the header includes, which is definitely good for code quality. The code changes are mostly related to the `ProtoApiEnums.h`. Without it, there would still be many files that have to include `PulsarApi.pb.h`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org