You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/31 13:42:23 UTC

[GitHub] [maven-parent] elharo opened a new pull request #20: [MPOM-250] remove taglets

elharo opened a new pull request #20:
URL: https://github.com/apache/maven-parent/pull/20


   @rfscholte 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-parent] asfgit closed pull request #20: [MPOM-250] remove taglets

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #20:
URL: https://github.com/apache/maven-parent/pull/20


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-parent] elharo commented on pull request #20: [MPOM-250] remove taglets

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #20:
URL: https://github.com/apache/maven-parent/pull/20#issuecomment-674850451


   Ping @rfscholte Is this good to merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-parent] slachiewicz commented on pull request #20: [MPOM-250] remove taglets

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #20:
URL: https://github.com/apache/maven-parent/pull/20#issuecomment-668246082


   Good reason to migrate our Maven Core ITs also to annotations


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-parent] rfscholte commented on pull request #20: [MPOM-250] remove taglets

Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #20:
URL: https://github.com/apache/maven-parent/pull/20#issuecomment-667514160


   Let's combine this by adding the following to the maven-plugin-plugin for the [descriptor-goal](https://maven.apache.org/plugin-tools/maven-plugin-plugin/descriptor-mojo.html#extractors) to ensure only the [JavaAnnotationsMojoDescriptorExtractor](https://maven.apache.org/plugin-tools/maven-plugin-tools-annotations/xref/org/apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.html#L82) is being used (with this taglets are really not used anymore):
   
        <extractors>
          <extractor>java-annotations</extractor>
        </extractors>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-parent] elharo commented on pull request #20: [MPOM-250] remove taglets

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #20:
URL: https://github.com/apache/maven-parent/pull/20#issuecomment-668237799


   done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org