You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2017/11/10 01:15:18 UTC
[07/11] beam git commit: NonNull by default in runners/core/metrics
NonNull by default in runners/core/metrics
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/da2a6066
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/da2a6066
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/da2a6066
Branch: refs/heads/master
Commit: da2a606676c6d6e9999d731340bbc3bbf9e7295a
Parents: 6fc163e
Author: Kenneth Knowles <kl...@google.com>
Authored: Sun Oct 29 21:08:06 2017 -0700
Committer: Kenneth Knowles <ke...@apache.org>
Committed: Thu Nov 9 15:01:55 2017 -0800
----------------------------------------------------------------------
.../beam/runners/core/metrics/MetricsContainerStepMap.java | 5 +++--
.../java/org/apache/beam/runners/core/metrics/package-info.java | 4 ++++
2 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/da2a6066/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java
----------------------------------------------------------------------
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java
index 14b8ccb..02ba8cb 100644
--- a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java
+++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java
@@ -25,6 +25,7 @@ import java.io.Serializable;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
+import javax.annotation.Nullable;
import org.apache.beam.runners.core.construction.metrics.MetricFiltering;
import org.apache.beam.runners.core.construction.metrics.MetricKey;
import org.apache.beam.runners.core.metrics.MetricUpdates.MetricUpdate;
@@ -425,14 +426,14 @@ public class MetricsContainerStepMap implements Serializable {
private final MetricName name;
private final String step;
private final T attempted;
- private final T committed;
+ private final @Nullable T committed;
private final boolean isCommittedSupported;
private AccumulatedMetricResult(
MetricName name,
String step,
T attempted,
- T committed,
+ @Nullable T committed,
boolean isCommittedSupported) {
this.name = name;
this.step = step;
http://git-wip-us.apache.org/repos/asf/beam/blob/da2a6066/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java
----------------------------------------------------------------------
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java
index 263a705..c08af82 100644
--- a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java
+++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java
@@ -19,4 +19,8 @@
/**
* Utilities for runners to implement metrics.
*/
+@DefaultAnnotation(NonNull.class)
package org.apache.beam.runners.core.metrics;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;