[jira] [Commented] (TEZ-1633) TestTaskRecovery.testRecovery_OneTA - expected:<1> but was:<2>

["Jeff Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152880#comment-14152880 ] 

Jeff Zhang commented on TEZ-1633:
---------------------------------

[~apivovarov] Thanks for your finding and patch.

I attach a new patch which invoke "dispatcher.await()" (wait until all the events is handled by Dispatcher).  We should not use Thread.sleep as possible as we can since it can not guarantee to solve the issue completely.  I saw you create a similar ticket [TEZ-1632|https://issues.apache.org/jira/browse/TEZ-1632], wondering whether we could solve the issue same way. 

> TestTaskRecovery.testRecovery_OneTA - expected:<1> but was:<2>
> --------------------------------------------------------------
>
>                 Key: TEZ-1633
>                 URL: https://issues.apache.org/jira/browse/TEZ-1633
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>         Attachments: TEZ-1633.1.patch, Tez-1633-2.patch
>
>
> $ mvn clean package
> {code}
> Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.747 sec <<< FAILURE!
> testRecovery_OneTAStarted(org.apache.tez.dag.app.dag.impl.TestTaskRecovery)  Time elapsed: 0.051 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<2>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.tez.dag.app.dag.impl.TestTaskRecovery.testRecovery_OneTAStarted(TestTaskRecovery.java:277)
> Running org.apache.tez.dag.app.dag.impl.TestVertexImpl
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)