You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/02/18 14:17:58 UTC
svn commit: r1731068 - in /jmeter/trunk/src/components/org/apache/jmeter:
assertions/ extractor/ reporters/ visualizers/ visualizers/backend/
visualizers/backend/graphite/
Author: pmouawad
Date: Thu Feb 18 13:17:58 2016
New Revision: 1731068
URL: http://svn.apache.org/viewvc?rev=1731068&view=rev
Log:
Removing unnecessary modifiers
Contributed by Graham Russel Part 1
https://github.com/apache/jmeter/pull/122
Modified:
jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/AbstractGraphiteMetricsSender.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteMetricsSender.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java Thu Feb 18 13:17:58 2016
@@ -75,7 +75,7 @@ public class ResponseAssertion extends A
* Mask values for TEST_TYPE TODO: remove either MATCH or CONTAINS - they
* are mutually exclusive
*/
- private static final int MATCH = 1 << 0;
+ private static final int MATCH = 1; // 1 << 0;
private static final int CONTAINS = 1 << 1;
Modified: jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java Thu Feb 18 13:17:58 2016
@@ -208,7 +208,7 @@ public class HtmlExtractor extends Abstr
* @param impl Extractor implementation
* @return Extractor
*/
- public static final Extractor getExtractorImpl(String impl) {
+ public static Extractor getExtractorImpl(String impl) {
boolean useDefaultExtractor = DEFAULT_EXTRACTOR.equals(impl);
if (useDefaultExtractor || EXTRACTOR_JSOUP.equals(impl)) {
return new JSoupExtractor();
Modified: jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java Thu Feb 18 13:17:58 2016
@@ -48,10 +48,10 @@ import org.apache.log.Logger;
*
*/
public class MailerModel extends AbstractTestElement implements Serializable {
- public static enum MailAuthType {
+ public enum MailAuthType {
SSL,
TLS,
- NONE;
+ NONE
}
private static final long serialVersionUID = 270L;
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java Thu Feb 18 13:17:58 2016
@@ -260,7 +260,7 @@ public class SearchTextExtension impleme
* Search provider definition
* Allow the search extension to search on any component
*/
- public static interface ISearchTextExtensionProvider {
+ public interface ISearchTextExtensionProvider {
/**
* reset the provider
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java Thu Feb 18 13:17:58 2016
@@ -259,8 +259,9 @@ public class BackendListener extends Abs
* @param context {@link BackendListenerContext}
* @param sampleResults List of {@link SampleResult}
*/
- static final void sendToListener(final BackendListenerClient backendListenerClient,
- final BackendListenerContext context,
+ static void sendToListener(
+ final BackendListenerClient backendListenerClient,
+ final BackendListenerContext context,
final List<SampleResult> sampleResults) {
if (sampleResults.size() > 0) {
backendListenerClient.handleSampleResults(sampleResults, context);
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java Thu Feb 18 13:17:58 2016
@@ -241,7 +241,8 @@ public class BackendListenerGui extends
* @param className String class name
* @return boolean true if model contains className
*/
- private static final boolean checkContainsClassName(ComboBoxModel<?> model, String className) {
+ private static boolean checkContainsClassName(
+ ComboBoxModel<?> model, String className) {
int size = model.getSize();
Set<String> set = new HashSet<>(size);
for (int i = 0; i < size; i++) {
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/AbstractGraphiteMetricsSender.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/AbstractGraphiteMetricsSender.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/AbstractGraphiteMetricsSender.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/AbstractGraphiteMetricsSender.java Thu Feb 18 13:17:58 2016
@@ -63,7 +63,7 @@ abstract class AbstractGraphiteMetricsSe
* text to be sanitized
* @return the sanitized text
*/
- static final String sanitizeString(String s) {
+ static String sanitizeString(String s) {
// String#replace uses regexp
return StringUtils.replaceChars(s, "\\ .", "--_");
}
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteMetricsSender.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteMetricsSender.java?rev=1731068&r1=1731067&r2=1731068&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteMetricsSender.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteMetricsSender.java Thu Feb 18 13:17:58 2016
@@ -22,8 +22,8 @@ package org.apache.jmeter.visualizers.ba
* @since 2.13
*/
interface GraphiteMetricsSender {
- final int SOCKET_CONNECT_TIMEOUT_MS = 1000;
- final int SOCKET_TIMEOUT = 1000;
+ int SOCKET_CONNECT_TIMEOUT_MS = 1000;
+ int SOCKET_TIMEOUT = 1000;
String CHARSET_NAME = "UTF-8"; //$NON-NLS-1$