[GitHub] [hive] coufon commented on a change in pull request #2421: HIVE-25277: fix slow partition deletion issue by removing duplicated isEmpty checks.

[GitBox <gi...@apache.org>]

coufon commented on a change in pull request #2421:
URL: https://github.com/apache/hive/pull/2421#discussion_r658120606



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -5088,10 +5089,8 @@ private boolean isDatabaseRemote(String name) {
 
   private void deleteParentRecursive(Path parent, int depth, boolean mustPurge, boolean needRecycle)

Review comment:
       I think it works if deleteDir fails when the dir is non-empty with no side effect. But we need to make sure all filesystems that Hive supports work in this way. Also I noticed that deleteDir calls moveToTrash first, so it could be more complex: https://github.com/apache/hive/blob/f2de30ca8bc2b63887496775f9a0769057a17ee0/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreFsImpl.java#L41. Avoiding duplicated checks seems to be safer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org