You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Andrew Kyle Purtell (Jira)" <ji...@apache.org> on 2022/04/30 02:03:00 UTC

[jira] [Commented] (HBASE-26886) Add unit test for custom RpcControllerFactory's ability to overwrite priorities

    [ https://issues.apache.org/jira/browse/HBASE-26886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530303#comment-17530303 ] 

Andrew Kyle Purtell commented on HBASE-26886:
---------------------------------------------

The PR had two approvals so I merged it. [~zhangduo] suggested in a review comment that we should also add an example to hbase-examples of how to do this. Please consider filing a follow up issue for that [~bbeaudreault]

> Add unit test for custom RpcControllerFactory's ability to overwrite priorities
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-26886
>                 URL: https://issues.apache.org/jira/browse/HBASE-26886
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Bryan Beaudreault
>            Assignee: Bryan Beaudreault
>            Priority: Minor
>              Labels: patch-available
>             Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.12
>
>
> We're planning on using the pluggable nature of RpcControllerFactory to send along custom priorities that are calculated based on some special logic in our stack. Unfortunately it's virtually impossible to test this from user code. On the other hand it's relatively easy to test within the hbase codebase. We should add a test class which verifies for users that this logic works. Then it's just up to them to test their own implementation of their HBaseRpcController rather than do the full integration test.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)