You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2009/05/15 01:24:45 UTC
[jira] Created: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
-------------------------------------------------------------------------------------------------------------------
Key: HADOOP-5841
URL: https://issues.apache.org/jira/browse/HADOOP-5841
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Jakob Homan
Assignee: Jakob Homan
Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5841:
--------------------------------
Status: Patch Available (was: Open)
Re-submitting to Hudson...
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711256#action_12711256 ]
Jakob Homan commented on HADOOP-5841:
-------------------------------------
No new tests as are small javac warning fixes. Not testable.
Failing contrib tests are known bad.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5841:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Jakob!
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711095#action_12711095 ]
Hadoop QA commented on HADOOP-5841:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408292/HADOOP-5841.patch
against trunk revision 776539.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/362/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/362/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/362/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/362/console
This message is automatically generated.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710010#action_12710010 ]
Jakob Homan commented on HADOOP-5841:
-------------------------------------
also, patch includes a couple minor tweaks of code and comments.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5841:
--------------------------------
Status: Open (was: Patch Available)
Canceling patch to try to get Hudson to notice it.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5841:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5841:
--------------------------------
Attachment: HADOOP-5841.patch
Patch addresses the findbugs warnings on the files specified in the JIRA title. Passes unit tests.
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
No unit tests as correcting minor code practices.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5841:
--------------------------------
Status: Patch Available (was: Open)
submitting patch
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5841) Resolve findbugs warnings in
DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java,
DataNodeDescriptor.java
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5841:
--------------------------------
Attachment: HADOOP-5841.patch
a couple tabs made it into the last patch. not sure how.
> Resolve findbugs warnings in DistributedFileSystem.java, DatanodeInfo.java, BlocksMap.java, DataNodeDescriptor.java
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5841
> URL: https://issues.apache.org/jira/browse/HADOOP-5841
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5841.patch, HADOOP-5841.patch
>
>
> Omnibus JIRA to address the findbugs issues raised in these files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.