You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Andrew Grieve (JIRA)" <ji...@apache.org> on 2013/04/03 03:10:13 UTC

[jira] [Commented] (CB-2641) InAppBrowser launched incorrectly when window.open called on iframes

    [ https://issues.apache.org/jira/browse/CB-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620474#comment-13620474 ] 

Andrew Grieve commented on CB-2641:
-----------------------------------

Tweaked your fix a bit (and re-tested using the attached .zip): https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=commit;h=a429d52bd92f91d132735f9607a7e1f45bbd78d5
                
> InAppBrowser launched incorrectly when window.open called on iframes
> --------------------------------------------------------------------
>
>                 Key: CB-2641
>                 URL: https://issues.apache.org/jira/browse/CB-2641
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: 2.4.0, 2.5.0
>         Environment: This bug is reproducible on all iOS devices and simulator for Cordova 2.4.0 and 2.5.0. The bug did not exist in Cordova 2.3.0.
>            Reporter: Mike Kwan
>            Assignee: Shazron Abdullah
>             Fix For: 2.7.0
>
>         Attachments: cordova_bug.zip, index.html, shared-frame.html, standard window.open.png, window.open erroneously opening iab.png
>
>
> window.open is overridden by Cordova to launch the InAppBrowser plugin. When window.open is called on iframes, the InAppBrowser is incorrectly launched. Putting the attached HTML files into www demonstrates:
> - the expected behaviour by using the native window.open
> - the bug in Cordova causing InAppBrowser to be launched instead after window.open is overridden
> - an example of a fix
> I have attached screenshots of expected vs actual behaviour and a minimal example project reproducing the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira