[kudu-CR] java: add support for flaky test reporting

["Mike Percy (Code Review)" <ge...@cloudera.org>]

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 )

Change subject: java: add support for flaky test reporting
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12042/7/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java:

http://gerrit.cloudera.org:8080/#/c/12042/7/java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java@173
PS7, Line 173:         if (result == ResultReporter.Result.SUCCESS) {
Is there a reason that we create a test log on success instead of failure? We are doing the opposite in the appender but I guess it doesn't really matter in this case since we are testing both paths and thus have coverage.



-- 
To view, visit http://gerrit.cloudera.org:8080/12042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34f88363dbf52c2f7bba50fbfb5de059f88e7f74
Gerrit-Change-Number: 12042
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 21:58:55 +0000
Gerrit-HasComments: Yes