[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #687: Add ShuffleWriter trait

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #687:
URL: https://github.com/apache/arrow-ballista/pull/687#discussion_r1118111745


##########
ballista/core/src/execution_plans/shuffle_writer.rs:
##########
@@ -139,7 +154,7 @@ impl ShuffleWriterExec {
         self.shuffle_output_partitioning.as_ref()
     }
 
-    pub fn execute_shuffle_write(
+    fn execute_shuffle_write_internal(

Review Comment:
   @tustvold You changed the signature of this method in https://github.com/apache/arrow-ballista/commit/b7bb2cfba13cc04a08c2f687102dd14a8dedc7b6 to change it from `async` to return an `impl Future`, and I am now calling it from an `async` method so just wanted to check that I am not undoing anything here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org