You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2007/01/12 02:18:27 UTC
[jira] Created: (QPID-281) Null protocolSession when closing
session in AMQPFastProtocolHandler (in inVM testing)
Null protocolSession when closing session in AMQPFastProtocolHandler (in inVM testing)
--------------------------------------------------------------------------------------
Key: QPID-281
URL: https://issues.apache.org/jira/browse/QPID-281
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: M1
Reporter: Martin Ritchie
public void sessionClosed(IoSession protocolSession) throws Exception
{
_logger.info("Protocol Session closed");
final AMQProtocolSession amqProtocolSession = AMQMinaProtocolSession.getAMQProtocolSession(protocolSession);
//fixme -- this can be null
amqProtocolSession.closeSession();
}
the protocolSession is occasionally null.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (QPID-281) Null protocolSession when closing
session in AMQPFastProtocolHandler (in inVM testing)
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-281:
--------------------------------
Fix Version/s: M3
> Null protocolSession when closing session in AMQPFastProtocolHandler (in inVM testing)
> --------------------------------------------------------------------------------------
>
> Key: QPID-281
> URL: https://issues.apache.org/jira/browse/QPID-281
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M1
> Reporter: Martin Ritchie
> Fix For: M3
>
> Attachments: AMQPFastProtocolHandler.java-20070116.patch
>
>
> public void sessionClosed(IoSession protocolSession) throws Exception
> {
> _logger.info("Protocol Session closed");
> final AMQProtocolSession amqProtocolSession = AMQMinaProtocolSession.getAMQProtocolSession(protocolSession);
> //fixme -- this can be null
> amqProtocolSession.closeSession();
> }
> the protocolSession is occasionally null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-281) Null protocolSession when closing
session in AMQPFastProtocolHandler (in inVM testing)
Posted by "Nuno Santos (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465267 ]
Nuno Santos commented on QPID-281:
----------------------------------
I've attached a patch to address the issue... if/when the session is null, closeSession would already have been called so can be skipped here. This is probably more evident with inVM testing because of timing.
> Null protocolSession when closing session in AMQPFastProtocolHandler (in inVM testing)
> --------------------------------------------------------------------------------------
>
> Key: QPID-281
> URL: https://issues.apache.org/jira/browse/QPID-281
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M1
> Reporter: Martin Ritchie
> Attachments: AMQPFastProtocolHandler.java-20070116.patch
>
>
> public void sessionClosed(IoSession protocolSession) throws Exception
> {
> _logger.info("Protocol Session closed");
> final AMQProtocolSession amqProtocolSession = AMQMinaProtocolSession.getAMQProtocolSession(protocolSession);
> //fixme -- this can be null
> amqProtocolSession.closeSession();
> }
> the protocolSession is occasionally null.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (QPID-281) Null protocolSession when closing
session in AMQPFastProtocolHandler (in inVM testing)
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved QPID-281.
------------------------------
Resolution: Fixed
Fix Version/s: (was: M3)
M2
> Null protocolSession when closing session in AMQPFastProtocolHandler (in inVM testing)
> --------------------------------------------------------------------------------------
>
> Key: QPID-281
> URL: https://issues.apache.org/jira/browse/QPID-281
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M1
> Reporter: Martin Ritchie
> Fix For: M2
>
> Attachments: AMQPFastProtocolHandler.java-20070116.patch
>
>
> public void sessionClosed(IoSession protocolSession) throws Exception
> {
> _logger.info("Protocol Session closed");
> final AMQProtocolSession amqProtocolSession = AMQMinaProtocolSession.getAMQProtocolSession(protocolSession);
> //fixme -- this can be null
> amqProtocolSession.closeSession();
> }
> the protocolSession is occasionally null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (QPID-281) Null protocolSession when closing session
in AMQPFastProtocolHandler (in inVM testing)
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey closed QPID-281.
----------------------------
> Null protocolSession when closing session in AMQPFastProtocolHandler (in inVM testing)
> --------------------------------------------------------------------------------------
>
> Key: QPID-281
> URL: https://issues.apache.org/jira/browse/QPID-281
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M1
> Reporter: Martin Ritchie
> Fix For: M2
>
> Attachments: AMQPFastProtocolHandler.java-20070116.patch
>
>
> public void sessionClosed(IoSession protocolSession) throws Exception
> {
> _logger.info("Protocol Session closed");
> final AMQProtocolSession amqProtocolSession = AMQMinaProtocolSession.getAMQProtocolSession(protocolSession);
> //fixme -- this can be null
> amqProtocolSession.closeSession();
> }
> the protocolSession is occasionally null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-281) Null protocolSession when closing
session in AMQPFastProtocolHandler (in inVM testing)
Posted by "Nuno Santos (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nuno Santos updated QPID-281:
-----------------------------
Attachment: AMQPFastProtocolHandler.java-20070116.patch
> Null protocolSession when closing session in AMQPFastProtocolHandler (in inVM testing)
> --------------------------------------------------------------------------------------
>
> Key: QPID-281
> URL: https://issues.apache.org/jira/browse/QPID-281
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M1
> Reporter: Martin Ritchie
> Attachments: AMQPFastProtocolHandler.java-20070116.patch
>
>
> public void sessionClosed(IoSession protocolSession) throws Exception
> {
> _logger.info("Protocol Session closed");
> final AMQProtocolSession amqProtocolSession = AMQMinaProtocolSession.getAMQProtocolSession(protocolSession);
> //fixme -- this can be null
> amqProtocolSession.closeSession();
> }
> the protocolSession is occasionally null.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira