[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6880: Delta Migration: Handle delta lake's automatic log clean and VACUUM

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6880:
URL: https://github.com/apache/iceberg/pull/6880#discussion_r1115307842


##########
delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:
##########
@@ -113,6 +124,8 @@ public static Object[][] parameters() {
   @Rule public TemporaryFolder temp3 = new TemporaryFolder();
   @Rule public TemporaryFolder temp4 = new TemporaryFolder();
   @Rule public TemporaryFolder temp5 = new TemporaryFolder();
+  @Rule public TemporaryFolder temp6 = new TemporaryFolder();
+  @Rule public TemporaryFolder temp7 = new TemporaryFolder();

Review Comment:
   can we try to avoid creating more temp folders? We should be able to reuse the same one for each test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org