You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/06/12 18:46:02 UTC

[lang] LANG-1059 Capitalize javadoc is incorrect Add test to show that first character is upcased, not the first (alphabetic) letter that is found

Repository: commons-lang
Updated Branches:
  refs/heads/master 5f479e70c -> 78e2f4c12


LANG-1059 Capitalize javadoc is incorrect
Add test to show that first character is upcased, not the first
(alphabetic) letter that is found

Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/78e2f4c1
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/78e2f4c1
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/78e2f4c1

Branch: refs/heads/master
Commit: 78e2f4c1223d45db3c5f7c20bf51586fbb566948
Parents: 5f479e7
Author: Sebb <se...@apache.org>
Authored: Fri Jun 12 17:45:57 2015 +0100
Committer: Sebb <se...@apache.org>
Committed: Fri Jun 12 17:45:57 2015 +0100

----------------------------------------------------------------------
 src/main/java/org/apache/commons/lang3/StringUtils.java     | 1 +
 src/test/java/org/apache/commons/lang3/StringUtilsTest.java | 7 +++++++
 2 files changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/78e2f4c1/src/main/java/org/apache/commons/lang3/StringUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java
index a927b78..968093a 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -5749,6 +5749,7 @@ public class StringUtils {
      * StringUtils.capitalize("")    = ""
      * StringUtils.capitalize("cat") = "Cat"
      * StringUtils.capitalize("cAt") = "CAt"
+     * StringUtils.capitalize("'cat'") = "'cat'"
      * </pre>
      *
      * @param str the String to capitalize, may be null

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/78e2f4c1/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
index 90447e4..49c9572 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsTest.java
@@ -249,6 +249,13 @@ public class StringUtilsTest {
                 FOO_CAP, StringUtils.capitalize(FOO_CAP));
         assertEquals("capitalize(string) failed",
                 FOO_CAP, StringUtils.capitalize(FOO_UNCAP));
+
+        // Javadoc examples
+        assertNull(StringUtils.capitalize(null));
+        assertEquals("", StringUtils.capitalize(""));
+        assertEquals("Cat", StringUtils.capitalize("cat"));
+        assertEquals("CAt", StringUtils.capitalize("cAt"));
+        assertEquals("'cat'", StringUtils.capitalize("'cat'"));
     }
 
     @Test