You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/13 14:20:38 UTC

[GitHub] [incubator-apisix] Miss-you opened a new pull request #1257: Add priority related information for plugin development doc

Miss-you opened a new pull request #1257: Add priority related information for plugin development doc
URL: https://github.com/apache/incubator-apisix/pull/1257
 
 
   Add priority related information for plugin development guide doc / plugin-develop-cn.md
   
   NOTE: Please read the Contributing.md guidelines before submitting your patch:
   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   SUMMARY_HERE
   
   ### Full changelog
   
   * [doc/plugin-develop-cn.md]
   
   ### Issues resolved
   
   Fix #XXX
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1257: Add priority related information for plugin development doc

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1257: Add priority related information for plugin development doc
URL: https://github.com/apache/incubator-apisix/pull/1257#discussion_r392258112
 
 

 ##########
 File path: doc/plugin-develop-cn.md
 ##########
 @@ -69,7 +69,7 @@
    }
 ```
 
-注：新插件的优先级（ priority 属性 ）不能与现有插件的优先级相同。
+注：新插件的优先级（ priority 属性 ）不能与现有插件的优先级相同。另外，优先级(priority)值大的插件，会优先执行，比如basic-auth的优先级是2520，ip-restriction的优先级是3000，所以在每个阶段，会先执行ip-restriction插件，再去执行basic-auth插件。
 
 Review comment:
   add a space between Chinese and English

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] juzhiyuan merged pull request #1257: Add priority related information for plugin development doc

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1257: Add priority related information for plugin development doc
URL: https://github.com/apache/incubator-apisix/pull/1257
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1257: Add priority related information for plugin development doc

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1257: Add priority related information for plugin development doc
URL: https://github.com/apache/incubator-apisix/pull/1257#discussion_r392258819
 
 

 ##########
 File path: doc/plugin-develop.md
 ##########
 @@ -19,12 +19,14 @@
 [中文](plugin-develop-cn.md)
 
 # table of contents
-- [**check dependencies**](#check-dependencies)
-- [**name and config**](#name-and-config)
-- [**schema and check**](#schema-and-check)
-- [**choose phase to run**](#choose-phase-to-run)
-- [**implement the logic**](#implement-the-logic)
-- [**write test case**](#write-test-case)
+- [table of contents](#table-of-contents)
 
 Review comment:
   if we changed the English version doc, we need to update the Chiese version too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services