[GitHub] [flink] tillrohrmann commented on pull request #14692: [FLINK-20944][k8s] Do not resolve the rest endpoint address when creating the RestClusterClient

[GitBox <gi...@apache.org>]

tillrohrmann commented on pull request #14692:
URL: https://github.com/apache/flink/pull/14692#issuecomment-763464134


   > Maybe we could add a log to remind users that the rest endpoint(e.g. webui, cancel, list, etc.) could only be used in the K8s cluster when service is exposed with ClusterIP.
   
   You mean when not using `ClusterIP`, right?
   
   I think it is ok that Flink does not know where it runs (outside or inside the K8s cluster). What should matter is whether we have to be able to talk to the cluster or not. If we have to talk to the cluster, then we have to be able to create a `ClusterClient` and should fail if we cannot connect to it (e.g. not being able to resolve the address).
   
   Would it make sense to say that we don't create a `ClusterClient` if we submit the cluster in detached mode? At the moment, this is not the case but it might make things a bit clearer.
   
   Another question, why does the `KubernetesClusterDescriptor.deployApplicationCluster` log the web interface URL? This looks not right because I would expect this kind of behaviour to happen for all `ClusterDescriptor` if at all. The `YarnClusterDescriptor` does not do this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org