You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/23 11:15:21 UTC

[GitHub] [apisix] membphis opened a new pull request #2105: plugin(fault-injection): use draft7 way to rewrite the JSON Schema.

membphis opened a new pull request #2105:
URL: https://github.com/apache/apisix/pull/2105


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   fix #2088
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2105: plugin(fault-injection): use draft7 way to rewrite the JSON Schema.

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2105:
URL: https://github.com/apache/apisix/pull/2105


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2105: plugin(fault-injection): use draft7 way to rewrite the JSON Schema.

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2105:
URL: https://github.com/apache/apisix/pull/2105#discussion_r478058278



##########
File path: apisix/plugins/fault-injection.lua
##########
@@ -28,26 +29,28 @@ local schema = {
                 http_status = {type = "integer", minimum = 200},
                 body = {type = "string", minLength = 0},

Review comment:
       we do not need default value. the default `http_status` is `200` for nginx.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2105: plugin(fault-injection): use draft7 way to rewrite the JSON Schema.

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2105:
URL: https://github.com/apache/apisix/pull/2105#discussion_r475490045



##########
File path: apisix/plugins/fault-injection.lua
##########
@@ -28,26 +29,28 @@ local schema = {
                 http_status = {type = "integer", minimum = 200},
                 body = {type = "string", minLength = 0},

Review comment:
       Should we set a default value for http_status and body property?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org