You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/04 12:44:10 UTC

[GitHub] [fineract] ptuomola opened a new pull request #819: FINERACT-910: Serving apiDocs as part of the fineract-provider

ptuomola opened a new pull request #819:
URL: https://github.com/apache/fineract/pull/819


   ## Description
   Configured Spring Boot to serve /static and /public directories from the classpath, and moved apiDocs to /static directory so that it will be served. Removed existing serving of '/apps/**' from cwd as a) that did not seem to be used and b) could be a potential security risk. 
   
   TODO: Below checklist needs to be updated with the correct location of api-docs - need to find where that is stored. 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [X] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [X] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [X] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [X] Integration tests have been created/updated for verifying the changes made.
   
   - [X] All Integrations tests are passing with the new commits.
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #819: FINERACT-910: Serving apiDocs as part of the fineract-provider

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #819:
URL: https://github.com/apache/fineract/pull/819#issuecomment-624268312


   > @ptuomola Great, thanks! Small thing: Would you perhaps like to add a trivial new integration test here, doing GET /apiDocs/ asset 200 instead of 400, just to ensure future non-regression for this? Just a thought.
   
   Sounds good - will do this tomorrow! 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #819: FINERACT-910: Serving apiDocs as part of the fineract-provider

Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #819:
URL: https://github.com/apache/fineract/pull/819#issuecomment-626126225


   Ping.. Whats left here maybe just the integration test otherwise everything looks great.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola edited a comment on pull request #819: FINERACT-910: Serving apiDocs as part of the fineract-provider

Posted by GitBox <gi...@apache.org>.
ptuomola edited a comment on pull request #819:
URL: https://github.com/apache/fineract/pull/819#issuecomment-624268312


   > @ptuomola Great, thanks! Small thing: Would you perhaps like to add a trivial new integration test here, doing GET /apiDocs/ asset 200 instead of 400, just to ensure future non-regression for this? Just a thought.
   
   @vorburger Sounds good - will do this tomorrow! 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #819: FINERACT-910: Serving apiDocs as part of the fineract-provider

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #819:
URL: https://github.com/apache/fineract/pull/819#issuecomment-626468435


   @awasum @vorburger I've added an integration test - so hopefully this is now good to go? Let me know if any other comments...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org