You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/22 17:27:00 UTC

[jira] [Created] (ARROW-8892) [C++][CI] CI builds for MSVC do not build benchmarks

Wes McKinney created ARROW-8892:
-----------------------------------

             Summary: [C++][CI] CI builds for MSVC do not build benchmarks
                 Key: ARROW-8892
                 URL: https://issues.apache.org/jira/browse/ARROW-8892
             Project: Apache Arrow
          Issue Type: Bug
          Components: C++
            Reporter: Wes McKinney
             Fix For: 1.0.0


We must ensure that our benchmarks always build on Windows

I'm fixing these errors for example in ARROW-8792

{code}
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(249): error C2220: warning treated as error - no 'object' file generated
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(256): note: see reference to function template instantiation 'void parquet::BM_PlainEncodingSpaced<parquet::BooleanType>(benchmark::State &)' being compiled
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(249): warning C4244: 'argument': conversion from 'const int64_t' to 'int', possible loss of data
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(292): warning C4244: 'argument': conversion from 'const int64_t' to 'int', possible loss of data
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(306): note: see reference to function template instantiation 'void parquet::BM_PlainDecodingSpaced<parquet::BooleanType>(benchmark::State &)' being compiled
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(299): warning C4244: 'argument': conversion from 'int64_t' to 'int', possible loss of data
C:/Users/wesmc/code/arrow/cpp/src/parquet/encoding_benchmark.cc(300): warning C4244: 'argument': conversion from 'const int64_t' to 'int', possible loss of data
[11/67] Linking CXX executable release\arrow-ipc-read-write-benchmark.exe
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)