You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "kszucs (via GitHub)" <gi...@apache.org> on 2025/11/19 11:33:36 UTC
[PR] feat(hugginface): allow specifying huggingface endpoint [opendal]
kszucs opened a new pull request, #6801:
URL: https://github.com/apache/opendal/pull/6801
# Rationale for this change
Huggingface Private Hub may use [custom endpoint](https://huggingface.co/docs/huggingface_hub/v0.13.2/en/package_reference/environment_variables#hfendpoint), it is also useful for enabling open source projects to use https://hub-ci.huggingface.co for testing.
# What changes are included in this PR?
Add support for configuring huggingface endpoint. If not provided, it tries to read from `HF_ENDPOINT` environment variable.
It also fixes a bug when passing revision which must be encoded, like `refs/convert/parquet` should be encoded as `refs%2Fconvert%2Fparquet`.
# Are there any user-facing changes?
There is a new builder method called `.endpoint()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(hugginface): allow specifying huggingface endpoint [opendal]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #6801:
URL: https://github.com/apache/opendal/pull/6801#issuecomment-3552861019
Thanks @Xuanwo for reviewing and merging!
> > it is also useful for enabling open source projects to use https://hub-ci.huggingface.co for testing.
>
> We can set up another integration test for https://hub-ci.huggingface.co at https://github.com/apache/opendal/tree/main/.github/services/huggingface/huggingface.
>
> Is this endpoint available for registration? I can help set up this test infra.
Yes. @lhoestq can give more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(hugginface): allow specifying huggingface endpoint [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6801:
URL: https://github.com/apache/opendal/pull/6801#issuecomment-3552370057
> it is also useful for enabling open source projects to use https://hub-ci.huggingface.co for testing.
We can set up another integration test for https://hub-ci.huggingface.co at https://github.com/apache/opendal/tree/main/.github/services/huggingface/huggingface.
Is this endpoint available for registration? I can help set up this test infra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(hugginface): allow specifying huggingface endpoint [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6801:
URL: https://github.com/apache/opendal/pull/6801#issuecomment-3552355223
> The produced URLs haven't been tested so I would need to mock the http client the assert on the created URLs, do you have an already established approach for that?
I think this change is simple enough to merge directly. Let's go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(hugginface): allow specifying huggingface endpoint [opendal]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #6801:
URL: https://github.com/apache/opendal/pull/6801#issuecomment-3552264695
The produced URLs haven't been tested so I would need to mock the http client the assert on the created URLs, do you have an already established approach for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(hugginface): allow specifying huggingface endpoint [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6801:
URL: https://github.com/apache/opendal/pull/6801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org