You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/04/30 12:54:23 UTC
[GitHub] [tinkerpop] spmallette commented on issue #1103: Create uber jar
for gremlin-console
spmallette commented on issue #1103: Create uber jar for gremlin-console
URL: https://github.com/apache/tinkerpop/pull/1103#issuecomment-487940512
I inspected the uberjar that is being generated. I have some concerns about the `META-INF/` in the jar itself with respect to licensing. I'm not sure what we need to include in there to be compliant with Apache licensing, but right now there's a bit of everything. I also think LICENSE files are copying over each other with the shading plugin. I assume that as this is a binary distribution artifact that the packaging should be similar to our zip distribution and follow that pattern, but I'll research a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services