You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ashish Vaidya <as...@yahoo.com> on 2012/08/10 18:55:34 UTC
Review Request: JIRA OOZIE-906 -- Runtime DAG plotting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6525/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Virag Kothari.
Description
-------
Please review the code for JIRA OOZIE-906 -- Runtime DAG plotting.
This addresses bug OOZIE-906.
https://issues.apache.org/jira/browse/OOZIE-906
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1371506
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/pom.xml 1364696
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowJob.java 1364696
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1364696
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1364696
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1364696
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1364696
Diff: https://reviews.apache.org/r/6525/diff/
Testing
-------
Thanks,
Ashish Vaidya
Re: Review Request: JIRA OOZIE-906 -- Runtime DAG plotting
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6525/#review10190
-----------------------------------------------------------
Great work!.. Some comments
The generated graph will have all the nodes, even the ones which are never actually processed (e.g the kill nodes in most cases). Should we just present the nodes in DAG which were processed? If yes, then we can directly get this information from db. (243 is already in and will provide information related to control nodes). This will eliminate the requirement to parse the job definition.
Can the separate attached files be put under SVN?. That will be make it easy to review and apply the patch before committing.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java
<https://reviews.apache.org/r/6525/#comment21597>
plz remove TABS..same comment for other places in code
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java
<https://reviews.apache.org/r/6525/#comment21599>
can an appropriate exception be thrown?
- Virag Kothari
On Aug. 10, 2012, 4:55 p.m., Ashish Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6525/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 4:55 p.m.)
>
>
> Review request for oozie, Mohammad Islam and Virag Kothari.
>
>
> Description
> -------
>
> Please review the code for JIRA OOZIE-906 -- Runtime DAG plotting.
>
>
> This addresses bug OOZIE-906.
> https://issues.apache.org/jira/browse/OOZIE-906
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1371506
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/pom.xml 1364696
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowJob.java 1364696
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 1364696
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1364696
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1364696
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1364696
>
> Diff: https://reviews.apache.org/r/6525/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Vaidya
>
>