[jira] [Commented] (SAMZA-1653) Support waitForFinish() in remote and add duration to both

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464025#comment-16464025 ] 

ASF GitHub Bot commented on SAMZA-1653:
---------------------------------------

GitHub user bharathkk opened a pull request:

    https://github.com/apache/samza/pull/503

    SAMZA-1653: Support waitForFinish in remote application runner and add waitForFinish

    Added the following APIs to AbstractApplicationRunner 
     `void waitForFinish()`
     `void waitForFinish(Duration timeout)`
    
    Implemented the wait for finish methods in remote application runner. Note currently, there is disparity in the APIs in terms of associating runners with stream application. Ideally, we want to decide on the cardinal relation between them and change the APIs accordingly. 
    
    The goal of the PR is limited to introduce API (waitForFinish) parity between runners in the current setup. 
    @xinyuiscool 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bharathkk/samza samza-1653

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #503
    
----
commit b8c3129054cf3f3adcac2d5196e46e3ecac31ee9
Author: Bharath Kumarasubramanian <bk...@...>
Date:   2018-04-30T16:22:39Z

    Support waitForFinish in remote application runner and add waitForFinish with duration

----


> Support waitForFinish() in remote and add duration to both
> ----------------------------------------------------------
>
>                 Key: SAMZA-1653
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1653
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Xinyu Liu
>            Assignee: Bharath Kumarasubramanian
>            Priority: Major
>             Fix For: 0.14.1
>
>
> WE need the consistent api for waitForFinish() in remote runner. This is for two reasons:
>  # feature parity with local runner
>  # for future use case if we support submit a batch job to a remote cluster and allow user program to wait till it completes to check the output.
> We need another variant of waitForFinish(duration). This is to be compatible with BEAM API. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)