You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/09/01 18:05:00 UTC
[jira] [Commented] (IMPALA-10884) Improve pretty-printing of
fragment instance name
[ https://issues.apache.org/jira/browse/IMPALA-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408312#comment-17408312 ]
ASF subversion and git services commented on IMPALA-10884:
----------------------------------------------------------
Commit 8a6439715f3d7780a408fe97b5f80a7a9a0c57c8 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8a64397 ]
IMPALA-10884: Improve pretty-printing of fragment instance name
The dense format of runtime profile print instance names in single long
lines. It is hard to observe the instance names, especially when a
fragment has many instances. This patch fixes the issue by breaking the
list into multiple lines, one line per instance. We also prefix the
instance names with an index number for easy matching against
pretty-printed counters, events, and info strings.
Testing:
- Fix and pass observability/test_profile_tool.py.
- Manually verify that impala-profile-tool prints the instance names in
multiple lines.
Change-Id: I03908ed2b29e43e133bff92c0d6480f8c5342f31
Reviewed-on: http://gerrit.cloudera.org:8080/17816
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Improve pretty-printing of fragment instance name
> -------------------------------------------------
>
> Key: IMPALA-10884
> URL: https://issues.apache.org/jira/browse/IMPALA-10884
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 4.0.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
> Fix For: Impala 4.0.1
>
>
> When using impala-profile-tool with extended verbosity, SummaryStatsCounter and TimeSeriesCounter coming from different instances are printed with prefix number like this:
>
> {code:java}
> - MemoryUsage[0] (2s000ms): 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 57.26 MB, 62.01 MB, 63.80 MB, 63.80 MB, 63.80 MB, 63.78 MB, 63.08 MB, 61.77 MB, 60.47 MB, 60.44 MB, 60.62 MB, 61.08 MB, 61.32 MB, 61.21 MB, 61.32 MB, 61.28 MB, 61.45 MB, 61.35 MB, 61.30 MB, 61.32 MB, 61.43 MB, 61.28 MB, 61.56 MB, 61.49 MB, 61.47 MB, 61.50 MB, 61.47 MB, 61.64 MB, 61.49 MB, 61.54 MB, 61.42 MB, 61.47 MB, 61.51 MB
> - MemoryUsage[1] (2s000ms): 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 32.64 MB, 57.42 MB, 63.74 MB, 63.74 MB, 63.74 MB, 63.74 MB, 63.89 MB, 63.41 MB, 61.98 MB, 62.72 MB, 61.88 MB, 61.24 MB, 61.09 MB, 61.15 MB, 61.17 MB, 61.47 MB, 61.63 MB, 61.68 MB, 61.38 MB, 61.57 MB, 61.58 MB, 61.44 MB, 61.61 MB, 61.62 MB, 61.37 MB, 61.64 MB, 61.63 MB, 61.36 MB, 61.70 MB, 61.49 MB, 61.45 MB, 61.48 MB, 61.50 MB, 61.44 MB
> - MemoryUsage[3] (2s000ms): 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 39.72 MB, 45.50 MB, 49.18 MB, 52.27 MB, 52.27 MB, 51.80 MB, 49.63 MB, 49.91 MB, 48.78 MB, 48.87 MB, 48.72 MB, 49.47 MB, 49.40 MB, 49.01 MB, 61.53 MB, 61.35 MB, 61.29 MB, 61.27 MB, 61.43 MB, 61.58 MB, 61.59 MB, 61.58 MB, 61.54 MB, 61.58 MB, 61.40 MB, 61.44 MB, 61.47 MB, 61.50 MB, 61.53 MB, 61.62 MB, 61.15 MB, 61.63 MB, 61.62 MB
> ...
> {code}
>
> The prefix number maps into fragment instance from where that counter is coming from. However, the fragment instance name is still printed in single long line without prefix number like this:
> {code:java}
> Fragment F00 [228 instances]:
> Instances: Instance 204c719f48777536:b83eb0ed00000001 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000002 (host=ia0306.halxg.cloudera.com:27000), , Instance 204c719f48777536:b83eb0ed00000004 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000005 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000006 (host=ia0306.halxg.cloudera.com:27000), , , Instance 204c719f48777536:b83eb0ed00000009 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000a (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000b (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000c (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000d (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000e (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000f (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000010 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000011 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000012 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000013 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000014 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000015 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000016 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000017 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000018 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000019 (host=ia0322.halxg.cloudera.com:27000), , , , Instance 204c719f48777536:b83eb0ed0000001d (host=ia0322.halxg.cloudera.com:27000), , , , Instance 204c719f48777536:b83eb0ed00000021 (host=ia0322.halxg.cloudera.com:27000), , , , Instance 204c719f48777536:b83eb0ed00000025 (host=ia0317.halxg.cloudera.com:27000), , , , ...{code}
> This makes it hard to match counters with their fragment instance. We should break thing long line into multiple line and add prefix number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org