You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/10 10:22:46 UTC

[GitHub] [nuttx] pussuw commented on a diff in pull request #8066: sched/group: fix task info heap-use-after-free

pussuw commented on code in PR #8066:
URL: https://github.com/apache/nuttx/pull/8066#discussion_r1065595100


##########
sched/group/group_leave.c:
##########
@@ -156,12 +155,6 @@ static inline void group_release(FAR struct task_group_s *group)
   pthread_release(group);
 #endif
 
-#ifdef CONFIG_FILE_STREAM
-  /* Free resource held by the stream list */
-
-  lib_stream_release(group);

Review Comment:
   Would it not suffice to just move this before line 140?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org