You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/02 08:31:39 UTC
[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request
#1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
break60 opened a new pull request #1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1680#issuecomment-570145793
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=h1) Report
> Merging [#1680](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1378de3ffdd4d72c00e15e071422c551f920a04c?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1680 +/- ##
==========================================
- Coverage 17.21% 17.18% -0.04%
==========================================
Files 284 285 +1
Lines 13853 13882 +29
Branches 2255 2264 +9
==========================================
Hits 2385 2385
- Misses 11193 11222 +29
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apache/dolphinscheduler/alert/utils/FuncUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9GdW5jVXRpbHMuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...he/dolphinscheduler/alert/utils/PropertyUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Qcm9wZXJ0eVV0aWxzLmphdmE=) | `88.23% <ø> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...apache/dolphinscheduler/alert/utils/JSONUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9KU09OVXRpbHMuamF2YQ==) | `80% <ø> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/common/utils/StringUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1N0cmluZ1V0aWxzLmphdmE=) | `1.53% <0%> (-0.64%)` | :arrow_down: |
| [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [.../apache/dolphinscheduler/common/utils/IOUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0lPVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=footer). Last update [1378de3...895d38f](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1680:
Fixed DAG zoom in and zoom out nodes separated from arrows #1679
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1680#issuecomment-570145793
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=h1) Report
> Merging [#1680](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/e8b9f8969a9a08c54fc090e28a60fe0a12432127?src=pr&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1680 +/- ##
==========================================
+ Coverage 14.92% 15.09% +0.17%
==========================================
Files 284 283 -1
Lines 13960 13801 -159
Branches 2270 2244 -26
==========================================
Hits 2083 2083
+ Misses 11655 11496 -159
Partials 222 222
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...hinscheduler/server/worker/task/http/HttpTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2h0dHAvSHR0cFRhc2suamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=footer). Last update [e8b9f89...5d9aeef](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1680#issuecomment-570145793
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=h1) Report
> Merging [#1680](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/22a2d43d7c491d5a1acc5176c4ca26b842d1c99b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1680 +/- ##
=======================================
Coverage 15.09% 15.09%
=======================================
Files 283 283
Lines 13801 13801
Branches 2244 2244
=======================================
Hits 2083 2083
Misses 11496 11496
Partials 222 222
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=footer). Last update [22a2d43...5d9aeef](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1680:
Fixed DAG zoom in and zoom out nodes separated from arrows #1679
Posted by GitBox <gi...@apache.org>.
lgcareer merged pull request #1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1680: Fixed DAG zoom in and zoom out nodes separated from arrows #1679
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1680#issuecomment-570145793
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@216154d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1680 +/- ##
======================================
Coverage ? 17.21%
======================================
Files ? 284
Lines ? 13853
Branches ? 2255
======================================
Hits ? 2385
Misses ? 11193
Partials ? 275
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=footer). Last update [216154d...1378de3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services