[jira] Commented: (BUILDR-325) Let packages be defined with the same type but a different classifier

["Alex Boisvert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761063#action_12761063 ] 

Alex Boisvert commented on BUILDR-325:
--------------------------------------

FYI, I added a few packaging specs to reveal this issue but coudln't ...

boisvert@sixtine:~/svn/buildr-325/spec$ svn commit -m "Add a few more packaging specs"
Sending        spec/packaging/packaging_spec.rb
Transmitting file data .
Committed revision 820502.


> Let packages be defined with the same type but a different classifier
> ---------------------------------------------------------------------
>
>                 Key: BUILDR-325
>                 URL: https://issues.apache.org/jira/browse/BUILDR-325
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Antoine Toulme
>         Attachments: buildrpatch
>
>
> The current code in package.rb does this:
> package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] ||
>           packages.find { |pkg| pkg.name == file_name }                             ||
>           packager.call(file_name)
> ie, if you define two packages that use the :zip type, only the first one will be taken into account.
> I happen to work on Eclipse features, in which both the source and original features work with the same type, but have different classifiers.
> So I'd like the code to do this instead:
> package = (no_options && packages.detect { |pkg| pkg.type == spec[:type] && 
>                   (spec[:classifier].nil? || pkg.classifier == spec[:classifier])}) ||
>           packages.find { |pkg| pkg.name == file_name }                             ||
>           packager.call(file_name)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.