You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/10 09:48:22 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25091:
[SPARK-28323][SQL][Python] PythonUDF should be able to use in join condition
HyukjinKwon commented on a change in pull request #25091: [SPARK-28323][SQL][Python] PythonUDF should be able to use in join condition
URL: https://github.com/apache/spark/pull/25091#discussion_r301978321
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
##########
@@ -969,4 +970,26 @@ class JoinSuite extends QueryTest with SharedSQLContext {
Seq(Row(0.0d, 0.0/0.0)))))
}
}
+
+ test("SPARK-28323: PythonUDF should be able to use in join condition") {
Review comment:
Nice. can we add an assume too? `assume(shouldTestPythonUDFs)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org