[GitHub] [accumulo] EdColeman commented on a diff in pull request #2842: Renaming ZooStore get/set property methods to get/set nodeData

[GitBox <gi...@apache.org>]

EdColeman commented on code in PR #2842:
URL: https://github.com/apache/accumulo/pull/2842#discussion_r936083870


##########
core/src/main/java/org/apache/accumulo/core/logging/FateLogger.java:
##########
@@ -80,8 +81,8 @@ public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) {
       }
 
       @Override
-      public Serializable getProperty(long tid, String prop) {
-        return store.getProperty(tid, prop);
+      public Serializable getNodeData(long tid, Fate.NodeData prop) {

Review Comment:
   Maybe `node` or `data` instead of prop?



##########
core/src/main/java/org/apache/accumulo/fate/AdminUtil.java:
##########
@@ -364,7 +364,7 @@ private FateStatus getTransactionStatus(ReadOnlyTStore<T> zs, Set<Long> filterTx
 
       zs.reserve(tid);
 
-      String debug = (String) zs.getProperty(tid, Fate.DEBUG_PROP);
+      String debug = (String) zs.getNodeData(tid, Fate.NodeData.TARGET_NODE);

Review Comment:
   Would `TARGET_DESC_NODE` indicate that it is information and not the "target repo" itself?



##########
core/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java:
##########
@@ -103,8 +103,8 @@ public TStatus waitForStatusChange(long tid, EnumSet<TStatus> expected) {
   }
 
   @Override
-  public Serializable getProperty(long tid, String prop) {
-    return store.getProperty(tid, prop);
+  public Serializable getNodeData(long tid, Fate.NodeData prop) {

Review Comment:
   `nodeData` instead of `prop` ?



##########
core/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java:
##########
@@ -132,7 +132,7 @@ enum TStatus {
    * @param prop
    *          name of property to retrieve.
    */
-  Serializable getProperty(long tid, String prop);
+  Serializable getNodeData(long tid, Fate.NodeData prop);

Review Comment:
   `nodeData` instead of `prop` ?



##########
core/src/main/java/org/apache/accumulo/fate/Fate.java:
##########
@@ -70,6 +65,29 @@
 
   private final AtomicBoolean keepRunning = new AtomicBoolean(true);
 
+  public enum NodeData {
+
+    TARGET_NODE("target_node"),

Review Comment:
   `target_desc_node` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org