You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/07/31 12:34:48 UTC

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment 

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13963


Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................

IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Using "hdfs:///tmp" as path for the test cases did not work in S3
environment.

Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
---
M tests/metadata/test_testcase_builder.py
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/13963/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 16:16:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 16:44:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4095/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 13:15:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13963

to look at the new patch set (#3).

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................

IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Using "hdfs:///tmp" as path for the test cases did not work in S3
environment.

Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
---
M tests/metadata/test_testcase_builder.py
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/13963/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13963

to look at the new patch set (#2).

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................

IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Using "hdfs:///tmp" as path for the test cases did not work in S3
environment.

Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
---
M tests/metadata/test_testcase_builder.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/13963/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4113/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 15:17:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 23:22:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4717/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 16:44:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4096/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 13:21:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13963 )

Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment
......................................................................

IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

Using "hdfs:///tmp" as path for the test cases did not work in S3
environment.

Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Reviewed-on: http://gerrit.cloudera.org:8080/13963
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_testcase_builder.py
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf6767c3275dc5deec75a36f797d0963f83839cf
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>