You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:49:03 UTC
[GitHub] [tez] guptanikhil007 opened a new pull request, #206: TEZ-4411: Update FileSaver dependency
guptanikhil007 opened a new pull request, #206:
URL: https://github.com/apache/tez/pull/206
### What changes were proposed in this pull request?
Update FileSaver dependency to latest bower supported dependency
### Why are the changes needed?
Previous dependency files were no longer available
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1111396369
@guptanikhil007 : I see, that's kind of my concern, as we want to fix precommit here too (not only local builds), I want to make sure that once we merge this change, precommit will work
are you aware of any functionalities that made precommit stuck with the Teleborder version?
I mean, what you attached:
```
[2022-04-27T05:02:43.468Z] | -1 | mvninstall | 14m 1s | root in master failed.
```
...exactly belongs to the log file I mentioned above:
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/1/artifact/out/branch-mvninstall-root.txt
precommit is supposed to pick up the source code changes in the pull request, I'm just looking for the reason why it failed, and tried to fetch Teleborder version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] guptanikhil007 commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
guptanikhil007 commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1111309074
@abstractdog
I checked the build locally and it seems everything is working as expected.
Their may be an issue with pre-commit pipeline.
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for tez 0.10.2-SNAPSHOT:
[INFO]
[INFO] tez ................................................ SUCCESS [ 30.072 s]
[INFO] hadoop-shim ........................................ SUCCESS [ 10.241 s]
[INFO] tez-api ............................................ SUCCESS [ 52.557 s]
[INFO] tez-build-tools .................................... SUCCESS [ 0.162 s]
[INFO] tez-common ......................................... SUCCESS [ 3.010 s]
[INFO] tez-runtime-internals .............................. SUCCESS [ 7.538 s]
[INFO] tez-runtime-library ................................ SUCCESS [ 8.932 s]
[INFO] tez-mapreduce ...................................... SUCCESS [ 7.238 s]
[INFO] tez-examples ....................................... SUCCESS [ 3.170 s]
[INFO] tez-dag ............................................ SUCCESS [ 20.194 s]
[INFO] tez-tests .......................................... SUCCESS [ 14.497 s]
[INFO] tez-ext-service-tests .............................. SUCCESS [ 3.875 s]
[INFO] tez-ui ............................................. SUCCESS [02:53 min]
[INFO] tez-plugins ........................................ SUCCESS [ 0.058 s]
[INFO] tez-protobuf-history-plugin ........................ SUCCESS [ 4.565 s]
[INFO] tez-yarn-timeline-history .......................... SUCCESS [ 5.371 s]
[INFO] tez-yarn-timeline-history-with-acls ................ SUCCESS [ 3.894 s]
[INFO] tez-yarn-timeline-cache-plugin ..................... SUCCESS [ 26.645 s]
[INFO] tez-yarn-timeline-history-with-fs .................. SUCCESS [ 3.879 s]
[INFO] tez-history-parser ................................. SUCCESS [ 31.786 s]
[INFO] tez-aux-services ................................... SUCCESS [ 38.671 s]
[INFO] tez-tools .......................................... SUCCESS [ 0.060 s]
[INFO] tez-perf-analyzer .................................. SUCCESS [ 0.045 s]
[INFO] tez-job-analyzer ................................... SUCCESS [ 3.656 s]
[INFO] tez-javadoc-tools .................................. SUCCESS [ 1.197 s]
[INFO] hadoop-shim-impls .................................. SUCCESS [ 0.042 s]
[INFO] hadoop-shim-2.8 .................................... SUCCESS [ 1.382 s]
[INFO] tez-dist ........................................... SUCCESS [ 47.991 s]
[INFO] Tez ................................................ SUCCESS [ 17.688 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:43 min
[INFO] Finished at: 2022-04-27T23:15:54+05:30
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
tez-yetus commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112925896
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 15m 51s | root in master failed. |
| +1 :green_heart: | javadoc | 1m 7s | master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 42s | master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 13s | the patch passed |
| +1 :green_heart: | jshint | 44m 58s | There were no new jshint issues. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 21s | tez-ui in the patch passed. |
| +1 :green_heart: | asflicense | 0m 47s | The patch does not generate ASF License warnings. |
| | | 74m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/206 |
| JIRA Issue | TEZ-4411 |
| Optional Tests | dupname asflicense javac javadoc unit jshint |
| uname | Linux d0cb5361bc9e 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 9f8d6fbd3 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| mvninstall | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/2/artifact/out/branch-mvninstall-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/2/testReport/ |
| Max. process+thread count | 88 (vs. ulimit of 5500) |
| modules | C: tez-ui U: tez-ui |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/2/console |
| versions | git=2.25.1 maven=3.6.3 jshint=2.12.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112933198
merged, created empty PR to check mvninstall phase: https://github.com/apache/tez/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112888942
> The lowest bower version available is 1.2.0.
>
> ```
> node_modules/bower/bin/bower install file-saver#v1.20150507.2 --save
> bower file-saver#v1.20150507.2 not-cached https://github.com/eligrey/FileSaver.js.git#v1.20150507.2
> bower file-saver#v1.20150507.2 resolve https://github.com/eligrey/FileSaver.js.git#v1.20150507.2
> bower file-saver#v1.20150507.2 ENORESTARGET No version found that was able to satisfy v1.20150507.2
>
> Additional error details:
> Available versions: 1.2.0, 1.2.1, 1.2.2, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.6, 1.3.7, 1.3.8, 2.0.0, 2.0.4, 2.0.2, 2.0.4
> ```
>
> @Deependra-Patel @abstractdog Should we go with 1.2.0?
I cannot tell honestly, I've just uploaded the one on my laptop to: https://issues.apache.org/jira/secure/attachment/13043100/FileSaver.js
so this is used to be downloaded most probably by bower from Teleborder, but there are couple of diffs with the current 1.2.0 too
instead of manually looking for changes, please do the following:
```
#download the latest 1.x from FileSaver.js
#go to master branch without this patch
#remove your current one in your local tez
cd tez-ui
rm ./src/main/webapp/bower_components/file-saver.js/FileSaver.js
mvn test #should fail as FileSaver.js is not present
#download a target FileSaver.js version and copy it destination
cp the_FileSaver_you_just_downloaded.js ./src/main/webapp/bower_components/file-saver.js/FileSaver.js
mvn test #should pass
```
if all tests pass, I'm fine with the version, no matter which 1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] tez-yetus commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
tez-yetus commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1110543408
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 17m 50s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 14m 1s | root in master failed. |
| +1 :green_heart: | javadoc | 0m 55s | master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 28s | master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 37s | the patch passed |
| +1 :green_heart: | jshint | 32m 49s | There were no new jshint issues. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 27s | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 27s | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 10s | tez-ui in the patch passed. |
| +1 :green_heart: | asflicense | 0m 36s | The patch does not generate ASF License warnings. |
| | | 73m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/206 |
| JIRA Issue | TEZ-4411 |
| Optional Tests | dupname asflicense javac javadoc unit jshint |
| uname | Linux 02ca00ae28d9 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 9f8d6fbd3 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| mvninstall | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/1/artifact/out/branch-mvninstall-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/1/testReport/ |
| Max. process+thread count | 88 (vs. ulimit of 5500) |
| modules | C: tez-ui U: tez-ui |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/1/console |
| versions | git=2.25.1 maven=3.6.3 jshint=2.12.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] Deependra-Patel commented on a diff in pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
Deependra-Patel commented on code in PR #206:
URL: https://github.com/apache/tez/pull/206#discussion_r861457879
##########
tez-ui/src/main/webapp/bower-shrinkwrap.json:
##########
@@ -26,6 +23,9 @@
"https://github.com/dockyard/qunit-notifications.git": {
"0.1.1": "7a13f6dba5a340e1cb9e0b64c1c711e4d7edaca1"
},
+ "https://github.com/eligrey/FileSaver.js.git": {
+ "1.3.4": "b4a918669accb81f184c610d741a4a8e1306aa27"
Review Comment:
I think it would make sense to point to same commit (https://github.com/eligrey/FileSaver.js/commit/b7cf622909258086bc63ad764d08fcaed780ab42) in this PR so there are no extra changes.
Upgrading can be handled in separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1110604354
thanks @guptanikhil007
I can see tez-ui is still failing with your patch, could you please check?
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-206/1/artifact/out/branch-mvninstall-root.txt
I can still see occurrences of "Teleborder" in the log file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] guptanikhil007 commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
guptanikhil007 commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112881748
The lowest bower version available is 1.2.0.
```
node_modules/bower/bin/bower install file-saver#v1.20150507.2 --save
bower file-saver#v1.20150507.2 not-cached https://github.com/eligrey/FileSaver.js.git#v1.20150507.2
bower file-saver#v1.20150507.2 resolve https://github.com/eligrey/FileSaver.js.git#v1.20150507.2
bower file-saver#v1.20150507.2 ENORESTARGET No version found that was able to satisfy v1.20150507.2
Additional error details:
Available versions: 1.2.0, 1.2.1, 1.2.2, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.6, 1.3.7, 1.3.8, 2.0.0, 2.0.4, 2.0.2, 2.0.4
```
@Deependra-Patel @abstractdog Should we go with 1.2.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112904407
thanks @guptanikhil007 , I'm about to merge this soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] Deependra-Patel commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
Deependra-Patel commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1113073745
> The lowest bower version available is 1.2.0.
>
> ```
> node_modules/bower/bin/bower install file-saver#v1.20150507.2 --save
> bower file-saver#v1.20150507.2 not-cached https://github.com/eligrey/FileSaver.js.git#v1.20150507.2
> bower file-saver#v1.20150507.2 resolve https://github.com/eligrey/FileSaver.js.git#v1.20150507.2
> bower file-saver#v1.20150507.2 ENORESTARGET No version found that was able to satisfy v1.20150507.2
>
> Additional error details:
> Available versions: 1.2.0, 1.2.1, 1.2.2, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.6, 1.3.7, 1.3.8, 2.0.0, 2.0.4, 2.0.2, 2.0.4
> ```
>
> @Deependra-Patel @abstractdog Should we go with 1.2.0?
What I meant was we could have kept the commit id `b7cf622909258086bc63ad764d08fcaed780ab42` instead of `b4a918669accb81f184c610d741a4a8e1306aa27` irrespective of what release version we use. That should probably checkout this repo to this specific commit, so everything remains same as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog merged pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog merged PR #206:
URL: https://github.com/apache/tez/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] guptanikhil007 commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
guptanikhil007 commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112893787
mvn test is passing with 1.2.0
```
1..947
# tests 947
# pass 947
# fail 0
# ok
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] guptanikhil007 commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
guptanikhil007 commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1111502969
```
[2022-04-27T05:02:43.468Z] | | | | master Compile Tests
[2022-04-27T05:02:43.468Z] | -1 | mvninstall | 14m 1s | root in master failed.
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | | | | Patch Compile Tests
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | +1 | mvninstall | 2m 37s | the patch passed
```
mvninstall on master will fail as the patch is not applied till this step.
Build Steps:
```
[2022-04-27T03:49:38.848Z] Confirming git environment
[2022-04-27T03:49:39.888Z] Re-execing under Docker
[2022-04-27T03:49:39.888Z] Removing old images
[2022-04-27T03:49:41.450Z] Docker Container Maintenance
[2022-04-27T03:49:41.450Z] Docker Image Creation
[2022-04-27T04:07:31.723Z] Confirming git environment
[2022-04-27T04:07:31.723Z] Re-exec mode detected. Continuing.
[2022-04-27T04:07:31.723Z] Determining needed tests
[2022-04-27T04:07:31.724Z] Checking for duplicated filenames that differ only in case
[2022-04-27T04:07:31.724Z] Checking for @author tags: patch
[2022-04-27T04:07:31.724Z] Checking for long paths: patch
[2022-04-27T04:07:31.724Z] Checking there are new or changed tests in the patch.
[2022-04-27T04:07:31.725Z] maven install: master
[2022-04-27T04:21:40.159Z] jshint plugin: master
[2022-04-27T04:26:04.808Z] Pre-patch javadoc verification on master
[2022-04-27T04:27:29.565Z] Cleaning the source tree
[2022-04-27T04:27:38.497Z] Applying patch to master
[2022-04-27T04:27:39.020Z] maven install: patch
[2022-04-27T04:30:23.564Z] jshint plugin: patch
[2022-04-27T04:58:54.471Z] Checking for whitespace issues.
[2022-04-27T04:58:56.046Z] javadoc verification: patch
[2022-04-27T04:59:51.288Z] Running unit tests
[2022-04-27T05:02:09.607Z] Determining number of ASF License errors
[2022-04-27T05:02:38.226Z] Writing Brief Text Report to /precommit/brief.txt
[2022-04-27T05:02:38.751Z] Adding comment to Github
[2022-04-27T05:02:40.351Z] Adding comment to Gitlab
[2022-04-27T05:02:40.876Z] Writing HTML to /precommit/report.htm
[2022-04-27T05:02:41.401Z] Adding comment to JIRA
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] abstractdog commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
abstractdog commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1112875975
thanks @guptanikhil007, makes sense, so it should work after merging
please consider @Deependra-Patel 's comment regarding the version, otherwise, looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] guptanikhil007 commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
guptanikhil007 commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1111327294
There is a failure on master but patch is passing:
```
[2022-04-27T05:02:43.468Z] | Vote | Subsystem | Runtime | Comment
[2022-04-27T05:02:43.468Z] ============================================================================
[2022-04-27T05:02:43.468Z] | 0 | reexec | 17m 50s | Docker mode activated.
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | | | | Prechecks
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | +1 | dupname | 0m 0s | No case conflicting files found.
[2022-04-27T05:02:43.468Z] | +1 | @author | 0m 0s | The patch does not contain any @author
[2022-04-27T05:02:43.468Z] | | | | tags.
[2022-04-27T05:02:43.468Z] | -1 | test4tests | 0m 0s | The patch doesn't appear to include any
[2022-04-27T05:02:43.468Z] | | | | new or modified tests. Please justify why
[2022-04-27T05:02:43.468Z] | | | | no new tests are needed for this patch.
[2022-04-27T05:02:43.468Z] | | | | Also please list what manual steps were
[2022-04-27T05:02:43.468Z] | | | | performed to verify this patch.
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | | | | master Compile Tests
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | -1 | mvninstall | 14m 1s | root in master failed.
[2022-04-27T05:02:43.468Z] | +1 | javadoc | 0m 55s | master passed with JDK Private
[2022-04-27T05:02:43.468Z] | | | | Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
[2022-04-27T05:02:43.468Z] | +1 | javadoc | 0m 28s | master passed with JDK Private
[2022-04-27T05:02:43.468Z] | | | | Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b
[2022-04-27T05:02:43.468Z] | | | | 07
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | | | | Patch Compile Tests
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | +1 | mvninstall | 2m 37s | the patch passed
[2022-04-27T05:02:43.468Z] | +1 | jshint | 32m 49s | There were no new jshint issues.
[2022-04-27T05:02:43.468Z] | +1 | whitespace | 0m 1s | The patch has no whitespace issues.
[2022-04-27T05:02:43.468Z] | +1 | javadoc | 0m 27s | the patch passed with JDK Private
[2022-04-27T05:02:43.468Z] | | | | Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
[2022-04-27T05:02:43.468Z] | +1 | javadoc | 0m 27s | the patch passed with JDK Private
[2022-04-27T05:02:43.468Z] | | | | Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b
[2022-04-27T05:02:43.468Z] | | | | 07
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | | | | Other Tests
[2022-04-27T05:02:43.468Z] +---------------------------------------------------------------------------
[2022-04-27T05:02:43.468Z] | +1 | unit | 2m 10s | tez-ui in the patch passed.
[2022-04-27T05:02:43.468Z] | +1 | asflicense | 0m 36s | The patch does not generate ASF License
[2022-04-27T05:02:43.468Z] | | | | warnings.
[2022-04-27T05:02:43.468Z] | | | 73m 6s |
[2022-04-27T05:02:43.468Z]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] guptanikhil007 commented on pull request #206: TEZ-4411: Update FileSaver dependency
Posted by GitBox <gi...@apache.org>.
guptanikhil007 commented on PR #206:
URL: https://github.com/apache/tez/pull/206#issuecomment-1110507693
Solution Credits:
@AnmolSun (Anmol Sundaram)
@abstractdog Please help with the review and merge as this is a blocker for other commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org