[GitHub] [airflow] norm commented on a diff in pull request #25795: Let timetables control generated run_ids.

[GitBox <gi...@apache.org>]

norm commented on code in PR #25795:
URL: https://github.com/apache/airflow/pull/25795#discussion_r949986401


##########
airflow/timetables/base.py:
##########
@@ -200,3 +203,15 @@ def next_dagrun_info(
             a DagRunInfo object when asked at another time.
         """
         raise NotImplementedError()
+
+    def generate_run_id(
+        self,
+        *,
+        run_type: "DagRunType",
+        logical_date: DateTime,
+        data_interval: Optional[DataInterval],
+        **extra,
+    ) -> str:
+        from airflow.models.dagrun import DagRun
+
+        return DagRun.generate_run_id(run_type, logical_date)

Review Comment:
   At first glance, I found it unexpected that the responsibility has moved here, but the code still lives on `DagRun`. Not a request for change, just an observation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org