You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by st...@apache.org on 2022/08/30 06:51:46 UTC
[superset] branch master updated: fix(dev-server run): Check for environment tag not being undefined (#21232)
This is an automated email from the ASF dual-hosted git repository.
stephenlyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new b354f2265a fix(dev-server run): Check for environment tag not being undefined (#21232)
b354f2265a is described below
commit b354f2265aab1e5569315364ecbcc314049aae5d
Author: Shubham Sinha <si...@gmail.com>
AuthorDate: Tue Aug 30 12:21:32 2022 +0530
fix(dev-server run): Check for environment tag not being undefined (#21232)
* fixed local dev-server run
* removed console log
* removed console log
---
.../components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx | 3 ---
superset-frontend/src/views/components/RightMenu.tsx | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
index bc59fb06e6..1eb77afb3e 100644
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
@@ -103,7 +103,6 @@ const ColumnSelectPopover = ({
const datasourceType = useSelector<ExplorePageState, string | undefined>(
state => state.explore.datasource.type,
);
- console.log('datasource', datasourceType);
const [initialLabel] = useState(label);
const [initialAdhocColumn, initialCalculatedColumn, initialSimpleColumn] =
getInitialColumnValues(editedColumn);
@@ -248,8 +247,6 @@ const ColumnSelectPopover = ({
const savedExpressionsLabel = t('Saved expressions');
const simpleColumnsLabel = t('Column');
- console.log(calculatedColumns.length > 0);
- console.log(datasourceType === DatasourceType.Query);
return (
<Form layout="vertical" id="metrics-edit-popover">
<Tabs
diff --git a/superset-frontend/src/views/components/RightMenu.tsx b/superset-frontend/src/views/components/RightMenu.tsx
index fabf071eb6..27f84a0be6 100644
--- a/superset-frontend/src/views/components/RightMenu.tsx
+++ b/superset-frontend/src/views/components/RightMenu.tsx
@@ -281,7 +281,7 @@ const RightMenu = ({
onDatabaseAdd={handleDatabaseAdd}
/>
)}
- {environmentTag.text && (
+ {environmentTag && environmentTag.text && (
<Label
css={{ borderRadius: `${theme.gridUnit * 125}px` }}
color={