You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/08/15 02:02:27 UTC
[GitHub] [tinkerpop] divijvaidya opened a new pull request #1311: Delegate processing from event loop to worker threads
divijvaidya opened a new pull request #1311:
URL: https://github.com/apache/tinkerpop/pull/1311
**Motivation**
Netty client has two thread pools. Event loop thread pool which is responsible for handling socket events and another is a worker thread pool which is used to delegate busy work from event loop threads so that they can continue handling socket events. When programming in Netty, ideally, the event loop should never be blocked and must be kept free to respond to events.
In case of exceptional completion of readComplete which could be triggered by a server sending an error code in the response, the event loop thread is used to perform the clean up logic which could involve an expensive replaceConnection. This blocks the event loop.
**Change**
Delegate handling of erroneous response from the server (which might involve connection replacement) to the worker thread pool. After this change the event loop will have lesser pressure and event handling will become faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] divijvaidya merged pull request #1311: TINKERPOP-2406 Delegate processing from event loop to worker threads
Posted by GitBox <gi...@apache.org>.
divijvaidya merged pull request #1311:
URL: https://github.com/apache/tinkerpop/pull/1311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1311: Delegate processing from event loop to worker threads
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1311:
URL: https://github.com/apache/tinkerpop/pull/1311#issuecomment-677713260
Could you please add a ticket in JIRA for this change? Aside from that, this makes sense - further freeing the event loop by delegating off tasks that don't need to be there is a good move. Please squash before merging.
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org