You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2015/12/28 23:53:30 UTC
Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1566
https://issues.apache.org/jira/browse/AURORA-1566
Repository: aurora
Description
-------
Release notes are here:
https://docs.gradle.org/2.10/release-notes
https://docs.gradle.org/2.9/release-notes
https://docs.gradle.org/2.8/release-notes
No-op compiles are 20% faster in local testing for example.
One hack was needed for pmd and a comment was added in `build.gradle
calling the shot for future removal.
build.gradle | 15 +++++++++++++++
buildSrc/gradle.properties | 2 +-
gradle/wrapper/gradle-wrapper.properties | 2 +-
3 files changed, 17 insertions(+), 2 deletions(-)
Diffs
-----
build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
Diff: https://reviews.apache.org/r/41755/diff/
Testing
-------
./gradlew -Pq build
Thanks,
John Sirois
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112099
-----------------------------------------------------------
Ship it!
Master (eec985d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 28, 2015, 11:59 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 11:59 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112094
-----------------------------------------------------------
Ship it!
Thanks!
- Bill Farner
On Dec. 28, 2015, 3:59 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 3:59 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 4:59 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Use more robust classpath nullification.
build.gradle | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
Bugs: AURORA-1566
https://issues.apache.org/jira/browse/AURORA-1566
Repository: aurora
Description
-------
Release notes are here:
https://docs.gradle.org/2.10/release-notes
https://docs.gradle.org/2.9/release-notes
https://docs.gradle.org/2.8/release-notes
No-op compiles are 20% faster in local testing for example.
One hack was needed for pmd and a comment was added in `build.gradle`
calling the shot for future removal.
build.gradle | 15 +++++++++++++++
buildSrc/gradle.properties | 2 +-
gradle/wrapper/gradle-wrapper.properties | 2 +-
3 files changed, 17 insertions(+), 2 deletions(-)
Diffs (updated)
-----
build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
Diff: https://reviews.apache.org/r/41755/diff/
Testing
-------
./gradlew -Pq build
Thanks,
John Sirois
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote:
> > Not sure if you saw but setting classpath to null was the suggested work around on my post on the gradle forum.
>
> John Sirois wrote:
> Ouch - did not. I played for a good while trying to build up the proper classpath and finally gave up trying to unset-it.
>
> John Sirois wrote:
> ... for example, amending the classpath to include sourceSets.main.compileClasspath / sourceSets.test.compileClasspath gets rid of all but 1 src/main and 1 src/test false positive. Those 2 though are in fact bugs in PMD's UnusedPrivateMethod checker.
OK - read that rec and his suggestion is cleaner, diff coming.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112088
-----------------------------------------------------------
On Dec. 28, 2015, 4:15 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 4:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote:
> > Not sure if you saw but setting classpath to null was the suggested work around on my post on the gradle forum.
>
> John Sirois wrote:
> Ouch - did not. I played for a good while trying to build up the proper classpath and finally gave up trying to unset-it.
... for example, amending the classpath to include sourceSets.main.compileClasspath / sourceSets.test.compileClasspath gets rid of all but 1 src/main and 1 src/test false positive. Those 2 though are in fact bugs in PMD's UnusedPrivateMethod checker.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112088
-----------------------------------------------------------
On Dec. 28, 2015, 4:15 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 4:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote:
> > Not sure if you saw but setting classpath to null was the suggested work around on my post on the gradle forum.
Ouch - did not. I played for a good while trying to build up the proper classpath and finally gave up trying to unset-it.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112088
-----------------------------------------------------------
On Dec. 28, 2015, 4:15 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 4:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112088
-----------------------------------------------------------
Ship it!
Not sure if you saw but setting classpath to null was the suggested work around on my post on the gradle forum.
- Zameer Manji
On Dec. 28, 2015, 3:15 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 3:15 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 4:15 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1566
https://issues.apache.org/jira/browse/AURORA-1566
Repository: aurora
Description (updated)
-------
Release notes are here:
https://docs.gradle.org/2.10/release-notes
https://docs.gradle.org/2.9/release-notes
https://docs.gradle.org/2.8/release-notes
No-op compiles are 20% faster in local testing for example.
One hack was needed for pmd and a comment was added in `build.gradle`
calling the shot for future removal.
build.gradle | 15 +++++++++++++++
buildSrc/gradle.properties | 2 +-
gradle/wrapper/gradle-wrapper.properties | 2 +-
3 files changed, 17 insertions(+), 2 deletions(-)
Diffs
-----
build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
Diff: https://reviews.apache.org/r/41755/diff/
Testing
-------
./gradlew -Pq build
Thanks,
John Sirois
Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112083
-----------------------------------------------------------
Ship it!
Master (eec985d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 28, 2015, 10:53 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 10:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1566
> https://issues.apache.org/jira/browse/AURORA-1566
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes are here:
> https://docs.gradle.org/2.10/release-notes
> https://docs.gradle.org/2.9/release-notes
> https://docs.gradle.org/2.8/release-notes
>
> No-op compiles are 20% faster in local testing for example.
>
> One hack was needed for pmd and a comment was added in `build.gradle
> calling the shot for future removal.
>
> build.gradle | 15 +++++++++++++++
> buildSrc/gradle.properties | 2 +-
> gradle/wrapper/gradle-wrapper.properties | 2 +-
> 3 files changed, 17 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89
> buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b
> gradle/wrapper/gradle-wrapper.properties 7eedd255dcda47350c645701ed2fc25d6b53ab96
>
> Diff: https://reviews.apache.org/r/41755/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> John Sirois
>
>