You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Mano Kovacs via Review Board <no...@reviews.apache.org> on 2017/10/25 19:01:18 UTC
Review Request 63303: SENTRY-1992 Improve parameter handling for
SentryGenericProviderBackend
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63303/
-----------------------------------------------------------
Review request for sentry and Sergio Pena.
Bugs: SENTRY-1992
https://issues.apache.org/jira/browse/SENTRY-1992
Repository: sentry
Description
-------
Adding external configuration options for SentryGenericProviderBackend to specify component and serviceName without informing the binding.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 280aebc844a42c056214d39c0be7b8a42bce6ab1
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java PRE-CREATION
Diff: https://reviews.apache.org/r/63303/diff/1/
Testing
-------
Thanks,
Mano Kovacs
Re: Review Request 63303: SENTRY-1992 Improve parameter handling for
SentryGenericProviderBackend
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63303/#review189302
-----------------------------------------------------------
Trivial nit - put a space before "=" here:
public static final String COMPONENT_TYPE= "sentry.provider.backend.generic.component-type";
Apart from that it looks fine to me.
- Colm O hEigeartaigh
On Oct. 25, 2017, 7:01 p.m., Mano Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63303/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 7:01 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1992
> https://issues.apache.org/jira/browse/SENTRY-1992
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adding external configuration options for SentryGenericProviderBackend to specify component and serviceName without informing the binding.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 280aebc844a42c056214d39c0be7b8a42bce6ab1
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63303/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mano Kovacs
>
>
Re: Review Request 63303: SENTRY-1992 Improve parameter handling for
SentryGenericProviderBackend
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63303/#review189415
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Oct. 27, 2017, 10:26 a.m., Mano Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63303/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 10:26 a.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1992
> https://issues.apache.org/jira/browse/SENTRY-1992
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adding external configuration options for SentryGenericProviderBackend to specify component and serviceName without informing the binding.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 280aebc844a42c056214d39c0be7b8a42bce6ab1
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63303/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mano Kovacs
>
>
Re: Review Request 63303: SENTRY-1992 Improve parameter handling for
SentryGenericProviderBackend
Posted by Mano Kovacs via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63303/
-----------------------------------------------------------
(Updated Oct. 27, 2017, 10:26 a.m.)
Review request for sentry and Sergio Pena.
Changes
-------
fixing nit
Bugs: SENTRY-1992
https://issues.apache.org/jira/browse/SENTRY-1992
Repository: sentry
Description
-------
Adding external configuration options for SentryGenericProviderBackend to specify component and serviceName without informing the binding.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 280aebc844a42c056214d39c0be7b8a42bce6ab1
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java PRE-CREATION
Diff: https://reviews.apache.org/r/63303/diff/2/
Changes: https://reviews.apache.org/r/63303/diff/1-2/
Testing
-------
Thanks,
Mano Kovacs
Re: Review Request 63303: SENTRY-1992 Improve parameter handling for
SentryGenericProviderBackend
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63303/#review189295
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Oct. 25, 2017, 7:01 p.m., Mano Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63303/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 7:01 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1992
> https://issues.apache.org/jira/browse/SENTRY-1992
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adding external configuration options for SentryGenericProviderBackend to specify component and serviceName without informing the binding.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 280aebc844a42c056214d39c0be7b8a42bce6ab1
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63303/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mano Kovacs
>
>
Re: Review Request 63303: SENTRY-1992 Improve parameter handling for
SentryGenericProviderBackend
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63303/#review189331
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Oct. 25, 2017, 7:01 p.m., Mano Kovacs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63303/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 7:01 p.m.)
>
>
> Review request for sentry and Sergio Pena.
>
>
> Bugs: SENTRY-1992
> https://issues.apache.org/jira/browse/SENTRY-1992
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adding external configuration options for SentryGenericProviderBackend to specify component and serviceName without informing the binding.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java 6c7d3efeb4757810dd8c0a31722e9997f40a3cbb
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 280aebc844a42c056214d39c0be7b8a42bce6ab1
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/TestSentryGenericProviderBackend.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63303/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mano Kovacs
>
>