You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/11/06 18:30:26 UTC
[GitHub] [pinot] jadami10 opened a new pull request, #9742: have query table list show search bar; fix InstancesTables filter
jadami10 opened a new pull request, #9742:
URL: https://github.com/apache/pinot/pull/9742
This is a `ui` `bugfix`
- adds the searchbox to the query tables list. every since pagination was added here, it's become a lot more challenging to scroll through tables when you have > 10 tables
- this fixes the `InstancesTables` page to only show the provided instances. right now it shows empty tables for all the other instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #9742: have query table list show search bar; fix InstancesTables filter
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9742:
URL: https://github.com/apache/pinot/pull/9742#issuecomment-1304872623
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9742](https://codecov.io/gh/apache/pinot/pull/9742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e44e411) into [master](https://codecov.io/gh/apache/pinot/commit/2f640ff8683728b844be9e045d5ce0f026d09e71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f640ff) will **decrease** coverage by `44.74%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #9742 +/- ##
=============================================
- Coverage 70.08% 25.33% -44.75%
+ Complexity 4980 44 -4936
=============================================
Files 1951 1939 -12
Lines 104561 104208 -353
Branches 15836 15798 -38
=============================================
- Hits 73279 26400 -46879
- Misses 26155 75092 +48937
+ Partials 5127 2716 -2411
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `25.33% <ø> (-0.11%)` | :arrow_down: |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9742?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/pinot/spi/utils/BytesUtils.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQnl0ZXNVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/spi/trace/BaseRecording.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvQmFzZVJlY29yZGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/spi/trace/NoOpRecording.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvTm9PcFJlY29yZGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/config/table/FSTType.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0ZTVFR5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/config/user/RoleType.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3VzZXIvUm9sZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/stream/StreamMessage.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbU1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1417 more](https://codecov.io/gh/apache/pinot/pull/9742/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on pull request #9742: have query table list show search bar; fix InstancesTables filter
Posted by GitBox <gi...@apache.org>.
jadami10 commented on PR #9742:
URL: https://github.com/apache/pinot/pull/9742#issuecomment-1312068883
@joshigaurava are you able to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jadami10 commented on a diff in pull request #9742: have query table list show search bar; fix InstancesTables filter
Posted by GitBox <gi...@apache.org>.
jadami10 commented on code in PR #9742:
URL: https://github.com/apache/pinot/pull/9742#discussion_r1024156161
##########
pinot-controller/src/main/resources/app/components/Homepage/InstancesTables.tsx:
##########
@@ -17,23 +17,30 @@
* under the License.
*/
-import React, { } from 'react';
-import map from 'lodash/map';
-import get from 'lodash/get';
+import React from 'react';
+import _ from 'lodash';
import InstanceTable from './InstanceTable';
-const Instances = ({instances, clusterName}) => {
+const Instances = ({ instances, clusterName }) => {
const order = ['Controller', 'Broker', 'Server', 'Minion'];
return (
<>
- {
- map(order, (key) => {
- const value = get(instances, key, []);
- return <InstanceTable key={key} name={`${key}s`} instances={value} clusterName={clusterName} />;
+ {_(order)
+ .filter((key) => _.has(instances, key))
+ .map((key) => {
+ const value = _.get(instances, key, []);
+ return (
+ <InstanceTable
+ key={key}
+ name={`${key}s`}
+ instances={value}
+ clusterName={clusterName}
+ />
+ );
Review Comment:
good call. forgot array already has those methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jayeshchoudhary commented on a diff in pull request #9742: have query table list show search bar; fix InstancesTables filter
Posted by GitBox <gi...@apache.org>.
jayeshchoudhary commented on code in PR #9742:
URL: https://github.com/apache/pinot/pull/9742#discussion_r1023903442
##########
pinot-controller/src/main/resources/app/components/Homepage/InstancesTables.tsx:
##########
@@ -17,23 +17,30 @@
* under the License.
*/
-import React, { } from 'react';
-import map from 'lodash/map';
-import get from 'lodash/get';
+import React from 'react';
+import _ from 'lodash';
import InstanceTable from './InstanceTable';
-const Instances = ({instances, clusterName}) => {
+const Instances = ({ instances, clusterName }) => {
const order = ['Controller', 'Broker', 'Server', 'Minion'];
return (
<>
- {
- map(order, (key) => {
- const value = get(instances, key, []);
- return <InstanceTable key={key} name={`${key}s`} instances={value} clusterName={clusterName} />;
+ {_(order)
+ .filter((key) => _.has(instances, key))
+ .map((key) => {
+ const value = _.get(instances, key, []);
+ return (
+ <InstanceTable
+ key={key}
+ name={`${key}s`}
+ instances={value}
+ clusterName={clusterName}
+ />
+ );
Review Comment:
I think we don't need `.value` here, we are simply filtering instances that don't have key.
```js
{order
.filter((key) => _.has(instances, key))
.map((key) => {
const value = _.get(instances, key, []);
return (
<InstanceTable
key={key}
name={`${key}s`}
instances={value}
clusterName={clusterName}
/>
);
})
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #9742: have query table list show search bar; fix InstancesTables filter
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged PR #9742:
URL: https://github.com/apache/pinot/pull/9742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org