You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "peng.jianhua (JIRA)" <ji...@apache.org> on 2017/09/12 02:05:02 UTC
[jira] [Comment Edited] (RANGER-1732) Collection added to itself
[ https://issues.apache.org/jira/browse/RANGER-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162352#comment-16162352 ]
peng.jianhua edited comment on RANGER-1732 at 9/12/17 2:05 AM:
---------------------------------------------------------------
i can fix it .
Thanks .
was (Author: peng.jianhua):
i can fix it
> Collection added to itself
> --------------------------
>
> Key: RANGER-1732
> URL: https://issues.apache.org/jira/browse/RANGER-1732
> Project: Ranger
> Issue Type: Bug
> Components: audit
> Reporter: JC
> Assignee: peng.jianhua
> Priority: Trivial
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> Path: agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
> {code:java}
> 32 Collection<AuthzAuditEvent> auditEvents = new ArrayList<>();
> ...
> 42
> 43 @Override
> 44 public void logAuthzAudits(Collection<AuthzAuditEvent> auditEvents) {
> 45 auditEvents.addAll(auditEvents);
> 46 }
> {code}
> In Line 45, `auditEvents.addAll' should be `this.auditEvents.addAll'? This might not be an issue but I wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)