[GitHub] [dolphinscheduler] Jeffrey12333 opened a new pull request, #11723: 修复alert插件http中Get请求没有带端口的问题--jeffrey

[GitBox <gi...@apache.org>]

Jeffrey12333 opened a new pull request, #11723:
URL: https://github.com/apache/dolphinscheduler/pull/11723

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   
   (or)
   
   If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #11723: [fix-#11723]Fix the problem that the get request in the alert plug-in HTTP does not have a port

[GitBox <gi...@apache.org>]

SbloodyS commented on PR #11723:
URL: https://github.com/apache/dolphinscheduler/pull/11723#issuecomment-1233624574

   Hi @Jeffrey12333 , to target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, just desc). It would not only connect issue to PR but also close issue automatically when PR is be closed. And please use english in the commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] Jeffrey12333 closed pull request #11723: [fix-#11723]Fix the problem that the get request in the alert plug-in HTTP does not have a port

[GitBox <gi...@apache.org>]

Jeffrey12333 closed pull request #11723: [fix-#11723]Fix the problem that the get request in the alert plug-in HTTP does not have a port
URL: https://github.com/apache/dolphinscheduler/pull/11723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org