You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hllqkb (via GitHub)" <gi...@apache.org> on 2026/07/06 14:54:46 UTC

Re: [PR] [Fix][Connector-V2] Normalize edge id to String + Fix HugeGraph Source connector issues [seatunnel]

hllqkb commented on PR #11340:
URL: https://github.com/apache/seatunnel/pull/11340#issuecomment-4894223290

   ## Commit d2f9c06dc — Fix Summary
   
   **Fix**: Normalize edge id to String in HugeGraph source reader
   
   ### What was changed
   - `HugeGraphSourceReader.java:214` — `fields[i] = edge.id()` → `fields[i] = String.valueOf(edge.id())`
   - Aligns edge `id` field with the inferred `STRING` schema, consistent with `mapVertex()` and `source_id`/`target_id`
   
   ### Root cause
   Commit 302f7718f partially fixed id normalization but missed `edge.id()` in `mapEdge()`. Identified through internal code consistency analysis: all other identifier fields (vertex.id, source_id, target_id) were already using `String.valueOf()`.
   
   ### Additional fixes in this commit
   1. Fixed incorrect assertion in `testReadEdges_withPropertyFilter` — `target_id` is a structural field, not filtered by `selectedProperties`
   2. Added regression test `testReadEdges_idNormalizedConsistentlyWithVertex` with complete field assertions
   
   ### Verification
   - Unit tests: 29 passed, 0 failed, 4 skipped
   - Spotless: PASS
   - Code review: APPROVED
   
   ### Investigation: UUID properties
   Checked hugegraph-client 1.5.0. `JsonUtil` uses default Jackson ObjectMapper (no UUID deserializer registered). UUID property values deserialize as `String`, so no additional fix needed for UUID attributes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org