You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/06/03 17:04:29 UTC

[GitHub] [curator] exceptionfactory opened a new pull request, #420: CURATOR-642 Upgrade Guava from 27.0.1 to 31.1

exceptionfactory opened a new pull request, #420:
URL: https://github.com/apache/curator/pull/420

   CURATOR-642 Upgrades Guava from 27.0.1 to 31.1 and replaces usage of Guava `Files.createTempDir()` with Java NIO `Files.createTempDirectory()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun commented on a diff in pull request #420: CURATOR-642 Upgrade Guava from 27.0.1 to 31.1

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #420:
URL: https://github.com/apache/curator/pull/420#discussion_r918522953


##########
curator-test/src/main/java/org/apache/curator/test/InstanceSpec.java:
##########
@@ -274,4 +276,13 @@ public int hashCode()
     {
         return hostname.hashCode() + port;
     }
+
+    private static File createTempDirectory() {

Review Comment:
   You may move this method to `DirectoryUtils`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun merged pull request #420: CURATOR-642 Upgrade Guava from 27.0.1 to 31.1

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #420:
URL: https://github.com/apache/curator/pull/420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] tisonkun commented on pull request #420: CURATOR-642 Upgrade Guava from 27.0.1 to 31.1

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #420:
URL: https://github.com/apache/curator/pull/420#issuecomment-1182664463

   Merging...
   
   Thanks for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] exceptionfactory commented on pull request #420: CURATOR-642 Upgrade Guava from 27.0.1 to 31.1

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #420:
URL: https://github.com/apache/curator/pull/420#issuecomment-1181734926

   Thanks for the feedback @tisonkun! I pushed an update moving `createTempDirectory` to `DirectoryUtils`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org