You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/21 06:19:11 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #1869: Alamb/cleanup decimal array
alamb opened a new pull request #1869:
URL: https://github.com/apache/arrow-datafusion/pull/1869
Draft as it builds on https://github.com/apache/arrow-datafusion/pull/1851
# Which issue does this PR close?
TBF
# Rationale for this change
Use a faster (less bounds checking) and more idiomatic API for creating `DecimalArray` mostly so that when others are looking for examples of how to create `DecimalArray`s they find one of these rather than `DecimalBuilder`
# What changes are included in this PR?
Cleans up some `DecimalArray` creation using APIs added in https://github.com/apache/arrow-rs/pull/1223
I didn't spend any time cleaning up binary.rs as I believe @liukun4515 has plans for that
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1869: [Minor] Clean up DecimalArray API Usage
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1869:
URL: https://github.com/apache/arrow-datafusion/pull/1869#issuecomment-1060622707
> I will go through the codebase and find any place needed to clean up.
Thank you @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1869: [Minor] Clean up DecimalArray API Usage
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1869:
URL: https://github.com/apache/arrow-datafusion/pull/1869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1869: Clean up DecimalArray API Usage
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1869:
URL: https://github.com/apache/arrow-datafusion/pull/1869#issuecomment-1059923038
I will review this tomorrow later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1869: [Minor] Clean up DecimalArray API Usage
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1869:
URL: https://github.com/apache/arrow-datafusion/pull/1869#issuecomment-1059953379
> ~Draft as it builds on #1851~
>
> # Which issue does this PR close?
> N/A
>
> # Rationale for this change
> Use a faster (less bounds checking) and more idiomatic API for creating `DecimalArray` mostly so that when others are looking for examples of how to create `DecimalArray`s they find one of these rather than `DecimalBuilder`
>
> # What changes are included in this PR?
> Cleans up some `DecimalArray` creation using APIs added in [apache/arrow-rs#1223](https://github.com/apache/arrow-rs/pull/1223)
>
> I didn't spend any time cleaning up binary.rs as I believe @liukun4515 has plans for that
>
> # Are there any user-facing changes?
Thanks for your refactor. @alamb
I will go through the codebase and find any place needed to clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org