[GitHub] [doris] HappenLee commented on a diff in pull request #16290: [Chore](build) enable -Wpedantic and update lowest gcc version to 11.1

["HappenLee (via GitHub)" <gi...@apache.org>]

HappenLee commented on code in PR #16290:
URL: https://github.com/apache/doris/pull/16290#discussion_r1093989604


##########
be/src/vec/common/string_ref.h:
##########
@@ -242,8 +243,8 @@ struct StringRef {
     StringRef trim() const;
 
     // support for type_limit
-    static constexpr char MIN_CHAR = 0x00;
-    static constexpr char MAX_CHAR = 0xFF;
+    static constexpr char MIN_CHAR = CHAR_MIN;
+    static constexpr char MAX_CHAR = CHAR_MAX;

Review Comment:
   Should be 0xFF， not `CHAR_MAX`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org