You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/12 20:34:22 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
amaliujia opened a new pull request, #38227:
URL: https://github.com/apache/spark/pull/38227
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Add sample to proto and connect DSL.
2. Add the missing plan comparison for column alias test case.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
3. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38227:
URL: https://github.com/apache/spark/pull/38227#issuecomment-1281815840
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994769825
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -73,6 +73,21 @@ package object dsl {
relation.setJoin(join).build()
}
+ def sample(
Review Comment:
I think we can go with the query plan for now and if we want to introduce optional behavior it's going to be easy to do because the proto supports optionality by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994254429
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -73,6 +73,21 @@ package object dsl {
relation.setJoin(join).build()
}
+ def sample(
Review Comment:
Are all of these parameters required? Or are some optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995329940
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
yes I was following existing practice.
The proto itself evolves fast. We need a lot more documentation on protobuf once it becomes stable a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994770464
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]].
Review Comment:
Maybe one more sentence of what the sampling does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995328272
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
`[[..]]` syntax is for Scaladoc to reference a class. Is it the same as protobuf? If not, we should probably just use backquotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994254021
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,11 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+message Sample {
Review Comment:
Doc please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38227:
URL: https://github.com/apache/spark/pull/38227#issuecomment-1278383229
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38227:
URL: https://github.com/apache/spark/pull/38227#issuecomment-1280665767
Are you good with this @grundprinzip ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r996585683
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
@HyukjinKwon Apache Beam's documentation for proto (which is from Google internal proto documentation style) is inspiring: https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto.
Eventually I think we will need do the same. Given that this proto is also an API layer, we gonna document on every of the field with semantic and examples. It will take time though once our proto becomes stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
URL: https://github.com/apache/spark/pull/38227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995328544
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
Maybe should be done separately because there seem many instances to fix here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995329940
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
yes I was following existing practice.
The proto itself evolves fast so probably we can ignore the doc quality for now. Documentation could be stale fast anyway.
We need revisit this and add a lot more documentation on protobuf once it becomes stable a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995328272
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,12 @@ message LocalRelation {
repeated Expression.QualifiedAttribute attributes = 1;
// TODO: support local data.
}
+
+// Relation of type [[Sample]] that samples a fraction of the dataset.
Review Comment:
`[[..]]` syntax is for Scaladoc to reference a column. Is it the same as protobuf? If not, we should probably just use backquotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994995220
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
We cannot. This is proto and for those primitive type there is no `set/unset`: they have default values.
For example, int32 if it is not set then the default value is 0, but user can also set 0. Server side does not know if this is set or not set, and 0 is a valid input.
The only solution I can think of is that we wrap each of the primitive type field into a message. However that complicate the proto and I am afraid that we don't want to go to that path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995110910
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
Let me add some comments.
Yeah if we ever find this is a true problem we can start to wrap those (maybe not for all fields but a few problematic ones when it applies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994776532
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
Since the proto arguments are not required, this means these values could be unset, this means that the transform function needs to check if the values are actually set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994995220
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
We cannot. This is proto and for those primitive type there is no `set/unset`: they have default values.
For example, int32 if it is not set then the default value is 0. Server side does not know if this is set or not set, and 0 is a valid input.
The only solution I can think of is that we wrap each of the primitive type field into a message. However that complicate the proto and I am afraid that we don't want to go to that path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38227:
URL: https://github.com/apache/spark/pull/38227#issuecomment-1276707331
R: @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994627656
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -73,6 +73,21 @@ package object dsl {
relation.setJoin(join).build()
}
+ def sample(
Review Comment:
are all required for the `Sample` query plan, but `df.sample` API has multiple overloads which provide default values for some parameters. Should the proto plan match query plan or DF API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994623934
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -73,6 +73,21 @@ package object dsl {
relation.setJoin(join).build()
}
+ def sample(
Review Comment:
are all required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994995485
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
cc @cloud-fan as this could be a question appearing over and over again when working with proto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r995079915
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -71,6 +72,15 @@ class SparkConnectPlanner(plan: proto.Relation, session: SparkSession) {
session.sessionState.sqlParser.parsePlan(sql.getQuery)
}
+ private def transformSample(rel: proto.Sample): LogicalPlan = {
+ Sample(
Review Comment:
Alright, I think this is something that we have to keep in mind when dealing with the protos. When we want optionality for scalar types we need to wrap them or properly deal with the zero initialized value.
I think in this case we can probably defer the checking to the analyzer because it will know if the value combination is invalid.
Maybe it's a good thing that we start some kind of developer docs with these caveats?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org