You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/01/13 23:01:29 UTC
Review Request 29867: Refactor the OS-dependent Ambari Server Windows
components - Part 1.3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29867/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
Bugs: AMBARI-8317
https://issues.apache.org/jira/browse/AMBARI-8317
Repository: ambari
Description
-------
+Merged serviceConfiguration*.py into serviceConfiguration.py
+Moved a series of configuration settings away from ambari-server.py
+Further optimized imports
Diffs
-----
ambari-agent/src/main/python/ambari_agent/HostCleanup.py a128dad20e01959f1219010a8c533e273fce7379
ambari-server/src/main/python/ambari-server-windows.py 5f9d58f4dc6bbd04223777fc2c7b88a4800774d8
ambari-server/src/main/python/ambari-server.py 6388dc634cda0af88f12e3a1d4666512e742647b
ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
ambari-server/src/main/python/ambari_server/serverConfiguration.py 6c436692b9bf91816e18d6ea71f20f91f1e4effe
ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
ambari-server/src/main/python/ambari_server/serverSetup.py b541ffc2014336dc59710e6868fae8e06a2e87d3
ambari-server/src/main/python/ambari_server/serverSetup_linux.py ea92a7de775db67a9308b4549900f27cb5d78867
ambari-server/src/main/python/ambari_server/serverSetup_windows.py 00b7d0bfd4bbc257434e833b0a3b5221ee949813
ambari-server/src/main/python/ambari_server/setupSecurity.py e6879b9502f2c2c12ad862b78125b178ea985914
ambari-server/src/main/python/ambari_server/userInput.py 54ad6c88886967b77d8ae404a39a7efe73a56f3c
ambari-server/src/test/python/TestAmbariServer.py 71d57a01cfafd6e6e2e59555517ad5287fd41744
ambari-server/src/test/python/TestOSCheck.py 026f747decd93e23e39f5480817900b0c4e5b97d
Diff: https://reviews.apache.org/r/29867/diff/
Testing
-------
mvn clean test
ambari_server setup
Thanks,
Florian Barca
Re: Review Request 29867: Refactor the OS-dependent Ambari Server
Windows components - Part 1.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29867/#review68175
-----------------------------------------------------------
Ship it!
mvn clean test
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [3.318s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.256s]
[INFO] Ambari Web ........................................ SUCCESS [32.813s]
[INFO] Ambari Views ...................................... SUCCESS [2.241s]
[INFO] Ambari Admin View ................................. SUCCESS [8.953s]
[INFO] Ambari Server ..................................... SUCCESS [29:41.390s]
[INFO] Ambari Agent ...................................... SUCCESS [9.531s]
[INFO] Ambari Client ..................................... SUCCESS [0.044s]
[INFO] Ambari Python Client .............................. SUCCESS [0.266s]
[INFO] Ambari Groovy Client .............................. SUCCESS [9.683s]
[INFO] Ambari Shell ...................................... SUCCESS [0.042s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.038s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.677s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:55.792s
[INFO] Finished at: Wed Jan 14 16:18:06 PST 2015
[INFO] Final Memory: 52M/396M
[INFO] ------------------------------------------------------------------------
- Jayush Luniya
On Jan. 13, 2015, 10:01 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29867/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 10:01 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8317
> https://issues.apache.org/jira/browse/AMBARI-8317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Merged serviceConfiguration*.py into serviceConfiguration.py
> +Moved a series of configuration settings away from ambari-server.py
> +Further optimized imports
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py a128dad20e01959f1219010a8c533e273fce7379
> ambari-server/src/main/python/ambari-server-windows.py 5f9d58f4dc6bbd04223777fc2c7b88a4800774d8
> ambari-server/src/main/python/ambari-server.py 6388dc634cda0af88f12e3a1d4666512e742647b
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
> ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 6c436692b9bf91816e18d6ea71f20f91f1e4effe
> ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
> ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
> ambari-server/src/main/python/ambari_server/serverSetup.py b541ffc2014336dc59710e6868fae8e06a2e87d3
> ambari-server/src/main/python/ambari_server/serverSetup_linux.py ea92a7de775db67a9308b4549900f27cb5d78867
> ambari-server/src/main/python/ambari_server/serverSetup_windows.py 00b7d0bfd4bbc257434e833b0a3b5221ee949813
> ambari-server/src/main/python/ambari_server/setupSecurity.py e6879b9502f2c2c12ad862b78125b178ea985914
> ambari-server/src/main/python/ambari_server/userInput.py 54ad6c88886967b77d8ae404a39a7efe73a56f3c
> ambari-server/src/test/python/TestAmbariServer.py 71d57a01cfafd6e6e2e59555517ad5287fd41744
> ambari-server/src/test/python/TestOSCheck.py 026f747decd93e23e39f5480817900b0c4e5b97d
>
> Diff: https://reviews.apache.org/r/29867/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ambari_server setup
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29867: Refactor the OS-dependent Ambari Server
Windows components - Part 1.3
Posted by Florian Barca <fb...@hortonworks.com>.
> On Jan. 15, 2015, 12:04 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py, line 128
> > <https://reviews.apache.org/r/29867/diff/1/?file=819956#file819956line128>
> >
> > We should cleanup MetricsSink related properties and code from ambari-server setup as we are migrating to AMS. That will also make linux and windows setup more similar and not require us to configure one more DB for Windows.
>
> Jayush Luniya wrote:
> You can do this cleanup in the next iteration.
Yes, it's in the plan. I would really like to avoid mixups, so it will most likely be the first thing after refactoring the setup.
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29867/#review68170
-----------------------------------------------------------
On Jan. 13, 2015, 10:01 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29867/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 10:01 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8317
> https://issues.apache.org/jira/browse/AMBARI-8317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Merged serviceConfiguration*.py into serviceConfiguration.py
> +Moved a series of configuration settings away from ambari-server.py
> +Further optimized imports
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py a128dad20e01959f1219010a8c533e273fce7379
> ambari-server/src/main/python/ambari-server-windows.py 5f9d58f4dc6bbd04223777fc2c7b88a4800774d8
> ambari-server/src/main/python/ambari-server.py 6388dc634cda0af88f12e3a1d4666512e742647b
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
> ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 6c436692b9bf91816e18d6ea71f20f91f1e4effe
> ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
> ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
> ambari-server/src/main/python/ambari_server/serverSetup.py b541ffc2014336dc59710e6868fae8e06a2e87d3
> ambari-server/src/main/python/ambari_server/serverSetup_linux.py ea92a7de775db67a9308b4549900f27cb5d78867
> ambari-server/src/main/python/ambari_server/serverSetup_windows.py 00b7d0bfd4bbc257434e833b0a3b5221ee949813
> ambari-server/src/main/python/ambari_server/setupSecurity.py e6879b9502f2c2c12ad862b78125b178ea985914
> ambari-server/src/main/python/ambari_server/userInput.py 54ad6c88886967b77d8ae404a39a7efe73a56f3c
> ambari-server/src/test/python/TestAmbariServer.py 71d57a01cfafd6e6e2e59555517ad5287fd41744
> ambari-server/src/test/python/TestOSCheck.py 026f747decd93e23e39f5480817900b0c4e5b97d
>
> Diff: https://reviews.apache.org/r/29867/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ambari_server setup
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29867: Refactor the OS-dependent Ambari Server
Windows components - Part 1.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Jan. 15, 2015, 12:04 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/python/ambari_server/serverConfiguration.py, line 128
> > <https://reviews.apache.org/r/29867/diff/1/?file=819956#file819956line128>
> >
> > We should cleanup MetricsSink related properties and code from ambari-server setup as we are migrating to AMS. That will also make linux and windows setup more similar and not require us to configure one more DB for Windows.
You can do this cleanup in the next iteration.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29867/#review68170
-----------------------------------------------------------
On Jan. 13, 2015, 10:01 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29867/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 10:01 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8317
> https://issues.apache.org/jira/browse/AMBARI-8317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Merged serviceConfiguration*.py into serviceConfiguration.py
> +Moved a series of configuration settings away from ambari-server.py
> +Further optimized imports
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py a128dad20e01959f1219010a8c533e273fce7379
> ambari-server/src/main/python/ambari-server-windows.py 5f9d58f4dc6bbd04223777fc2c7b88a4800774d8
> ambari-server/src/main/python/ambari-server.py 6388dc634cda0af88f12e3a1d4666512e742647b
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
> ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 6c436692b9bf91816e18d6ea71f20f91f1e4effe
> ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
> ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
> ambari-server/src/main/python/ambari_server/serverSetup.py b541ffc2014336dc59710e6868fae8e06a2e87d3
> ambari-server/src/main/python/ambari_server/serverSetup_linux.py ea92a7de775db67a9308b4549900f27cb5d78867
> ambari-server/src/main/python/ambari_server/serverSetup_windows.py 00b7d0bfd4bbc257434e833b0a3b5221ee949813
> ambari-server/src/main/python/ambari_server/setupSecurity.py e6879b9502f2c2c12ad862b78125b178ea985914
> ambari-server/src/main/python/ambari_server/userInput.py 54ad6c88886967b77d8ae404a39a7efe73a56f3c
> ambari-server/src/test/python/TestAmbariServer.py 71d57a01cfafd6e6e2e59555517ad5287fd41744
> ambari-server/src/test/python/TestOSCheck.py 026f747decd93e23e39f5480817900b0c4e5b97d
>
> Diff: https://reviews.apache.org/r/29867/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ambari_server setup
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 29867: Refactor the OS-dependent Ambari Server
Windows components - Part 1.3
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29867/#review68170
-----------------------------------------------------------
ambari-server/src/main/python/ambari_server/serverConfiguration.py
<https://reviews.apache.org/r/29867/#comment112328>
We should cleanup MetricsSink related properties and code from ambari-server setup as we are migrating to AMS. That will also make linux and windows setup more similar and not require us to configure one more DB for Windows.
- Jayush Luniya
On Jan. 13, 2015, 10:01 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29867/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 10:01 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
>
>
> Bugs: AMBARI-8317
> https://issues.apache.org/jira/browse/AMBARI-8317
>
>
> Repository: ambari
>
>
> Description
> -------
>
> +Merged serviceConfiguration*.py into serviceConfiguration.py
> +Moved a series of configuration settings away from ambari-server.py
> +Further optimized imports
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostCleanup.py a128dad20e01959f1219010a8c533e273fce7379
> ambari-server/src/main/python/ambari-server-windows.py 5f9d58f4dc6bbd04223777fc2c7b88a4800774d8
> ambari-server/src/main/python/ambari-server.py 6388dc634cda0af88f12e3a1d4666512e742647b
> ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48
> ambari-server/src/main/python/ambari_server/properties.py 8e00762d8158d4351544d0a1a88350bdc722332f
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 6c436692b9bf91816e18d6ea71f20f91f1e4effe
> ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02
> ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8
> ambari-server/src/main/python/ambari_server/serverSetup.py b541ffc2014336dc59710e6868fae8e06a2e87d3
> ambari-server/src/main/python/ambari_server/serverSetup_linux.py ea92a7de775db67a9308b4549900f27cb5d78867
> ambari-server/src/main/python/ambari_server/serverSetup_windows.py 00b7d0bfd4bbc257434e833b0a3b5221ee949813
> ambari-server/src/main/python/ambari_server/setupSecurity.py e6879b9502f2c2c12ad862b78125b178ea985914
> ambari-server/src/main/python/ambari_server/userInput.py 54ad6c88886967b77d8ae404a39a7efe73a56f3c
> ambari-server/src/test/python/TestAmbariServer.py 71d57a01cfafd6e6e2e59555517ad5287fd41744
> ambari-server/src/test/python/TestOSCheck.py 026f747decd93e23e39f5480817900b0c4e5b97d
>
> Diff: https://reviews.apache.org/r/29867/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> ambari_server setup
>
>
> Thanks,
>
> Florian Barca
>
>