You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/14 12:38:57 UTC
[GitHub] [camel-quarkus] davsclaus opened a new issue #3459: Extensions for camel-knative
davsclaus opened a new issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459
https://github.com/apache/camel-k-runtime/issues/752
Camel 3.15 comes with new components
- camel-knative
- camel-cloudevents
Camel K needs extensions for those, to be ported over from camel-k-runtime at
https://github.com/apache/camel-k-runtime/tree/main/camel-k-knative
https://github.com/apache/camel-k-runtime/tree/main/camel-k-cloudevents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on issue #3459: Camel 3.15 - Extensions for camel-knative and camel-cloudevents
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459#issuecomment-1023543828
I started working on this.
I'm not sure about this one [https://github.com/apache/camel-k-runtime/tree/main/camel-k-knative/impl](https://github.com/apache/camel-k-runtime/tree/main/camel-k-knative/impl)
what should I do for those 2 dependencies ?
```
<dependency>
<groupId>org.apache.camel.k</groupId>
<artifactId>camel-k-apt</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.apache.camel.k</groupId>
<artifactId>camel-k-annotations</artifactId>
<optional>true</optional>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on issue #3459: Camel 3.15 - Extensions for camel-knative and camel-cloudevents
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459#issuecomment-1023083468
@davsclaus My understanding is that the workaround for native mode is already done in camel-k-runtime. And the idea is to port this here as extensions, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on issue #3459: Camel 3.15 - Extensions for camel-knative and camel-cloudevents
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459#issuecomment-1061592104
I unassigned myself. I don't think I understand fully what to do with knative, knative-consumer and knative-producer. Do we create 3 extensions or combine in one? I'm not sure porting the integration tests in the project is enough to test if this could work fine for camel-k
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on issue #3459: Camel 3.15 - Extensions for camel-knative and camel-cloudevents
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459#issuecomment-1023553755
I think the annotations should be removed, however we need to reason about how to replicate the same feature with quarkus constructs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on issue #3459: Camel 3.15 - Extensions for camel-knative and camel-cloudevents
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459#issuecomment-1023166133
Yeah camel-k-runtime has already quarkus extensions for these 2 components, so yes the ticket is about moving the source code over to camel-quarkus - so we can remove them from camel-k-runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on issue #3459: Camel 3.15 - Extensions for camel-knative and camel-cloudevents
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on issue #3459:
URL: https://github.com/apache/camel-quarkus/issues/3459#issuecomment-1073624116
As discussed with @lburgazzoli:
- create 3 extensions : split the knative extension to 3 extensions : knative + knative-consumer + knative-producer. The consumer and producer extensions will be empty and unse the knative one. Those are for camel-k usage. Check if this could be improved later
- leave the [impl](https://github.com/apache/camel-k-runtime/tree/main/camel-k-knative/impl) part in camel-k-runtime for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org